Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp188031pxk; Thu, 24 Sep 2020 03:09:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzetEmzc2RKQCKa+rD5b7kk4DgW05aRESYjmIyyJZ99DeXnK/sFIhEzSkSN33x8m7ipc2d X-Received: by 2002:a17:906:c447:: with SMTP id ck7mr198381ejb.358.1600942143207; Thu, 24 Sep 2020 03:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600942143; cv=none; d=google.com; s=arc-20160816; b=JRpca+D9NtPSIOth1ttMLtSpbs/46lyj8LfQVLF+/hDCWxlUh5W5CZb8amShRep4gH ud3i4r5X03g6vF/JwIWjuPHdRQYZ/7pslyLalhE8hVrUllTE6V5L8nkWgAJhfCCNk+2l qucHpAX3bJHpQtQRJZ4+dpzT65H8U6TbTwWeX1wblbhmS7mBok1/ycs4rDQOWSgZtpm6 ZZe6VmeD7ZUIxo8k3uJisDVMGjKfLABcOPIY5ugRs78bzZZt2qzZDDJQmcW9sq0jS+I4 vpEuI4vu7TbvAq7nALMl0ze0ylCLF5Wqwp86xHPraKbTODrk1ivHHNW57lPtqHFmd4Fm 52qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:reply-to :in-reply-to:references:mime-version:dkim-signature; bh=KhTruP3MwdUdeacDNCordGViFr1P2f07pp/20Q2tnDU=; b=SUPp+kh2J/c9eiBUSPgKu8l93LwyMN6vpISAmc58U1byjT+B2kzYR3DljbXNzJ6GGR nsIU7PCxl9siCZox2pcB4q8PdTr3jDLmI8yipFyzBD+qJUYu1/akZAY2nkVffH3MQM1D AaLtfrxv5eWv+//IL4dwI/drN8nzjV84lvButXvEmF6p/HusWOQRaDspwTYMI9BKGyjD snzDiXsponZ1jyrF3NHWWYHpRg7APnzM+bkz+PHQxacOHQYtqUhGpigd9gLQl+qU3bDz YFghTVQkuchuVWYN9UVD9AXQET9HlpHnUpsdZyFHl987F6CUwX1IsMx2zDP174bhY0VT p6IQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=T5kPZAQO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si1947769edf.9.2020.09.24.03.08.13; Thu, 24 Sep 2020 03:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=T5kPZAQO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbgIXKFJ (ORCPT + 99 others); Thu, 24 Sep 2020 06:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgIXKFJ (ORCPT ); Thu, 24 Sep 2020 06:05:09 -0400 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE1F3C0613CE; Thu, 24 Sep 2020 03:05:08 -0700 (PDT) Received: by mail-ot1-x344.google.com with SMTP id u25so2611092otq.6; Thu, 24 Sep 2020 03:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=KhTruP3MwdUdeacDNCordGViFr1P2f07pp/20Q2tnDU=; b=T5kPZAQOvCK0EKyT3Pj/v7gj8dj+GYo3XEu02eX2zLhpboD5OLYZ4f1qcFDX6qgw8a inX2z6UFOfQUqr5QIwBelVm2+995dQY3DlD6E9m+0rOTOB6jTBRLTAaWZKNhkPmSrVUR OSa3DzrAGPjzJpIStcEkGYc6xkaTGyGl8TuYc0jN1HIt8FWT8ZQ034EYhlYVem4px9bL KYCwo1fJRuXNMrHRIR22ckV065GVmoo3dyyaALlIOfLe4GmD75Gh90qj25xT9kJ/L37O v80rYgesA6dR8crN9eiXqxZCymI9G4TogQ9JVJIItEoSVPgzUjdRz4Gg6A7kUh/iF3B7 BC3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=KhTruP3MwdUdeacDNCordGViFr1P2f07pp/20Q2tnDU=; b=dGkgdJNx/0NhlXc8FuzchCYoCIdQe0BG3h7FghJOWlxCz5LBfcgQxy8fdwZ4GHsir4 fbryIXK1NnTaQXYxoOLQBa3/HWEsqnaX0iWQYylPq392cZC0YKTM4YlyZQCimhM203Fy 4g9K2U/oYSUXP+3c0lTuMO2ARC+PQG3nZl27oRQ37zb+FS0wFTc9CNKwF3wHv+gbTLhx sa68V+dj5dFBERRgdHL9ajn9e9L0KXPajuaJITkQim4GP7frai23VxK7HPVdCEjACII9 owg4Ookev4cWps4tVyksqJSediA1JLFU6nLrnZJrX3ILBrL6TZUm+fZabVHnUnpEIDaf nK5w== X-Gm-Message-State: AOAM5314jAskBzG0QF1lO5vC5m31GzdhrgVKN931tRROGJFnt6mfOCHV uBjnaoGVfUo/FlBcDOdsTNF+VysT4ulGjJh5zks= X-Received: by 2002:a9d:2274:: with SMTP id o107mr2681695ota.323.1600941908259; Thu, 24 Sep 2020 03:05:08 -0700 (PDT) MIME-Version: 1.0 References: <20200910211344.3562-1-colomar.6.4.3@gmail.com> <20200910211344.3562-13-colomar.6.4.3@gmail.com> <7dd2ab72-3ce7-1f50-229a-e663c3df2dcd@gmail.com> In-Reply-To: Reply-To: mtk.manpages@gmail.com From: "Michael Kerrisk (man-pages)" Date: Thu, 24 Sep 2020 12:04:57 +0200 Message-ID: Subject: Re: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name) To: Alejandro Colomar Cc: Stefan Puiu , lnx-man , lkml , Walter Harms Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, [..] > I was reverting the 3 patches I introduced (they changed from solution 1 > to solution 2), and also was grepping for already existing solution 2 in > the pages (it seems that solution 2 was a bit more extended than > solution 1). Just so I can refresh my cache, which commits were those? Thanks, Michael