Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Sep 2020 12:21:39 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Felipe Balbi <balbi@kernel.org>
Cc:     Tang Bin <tangbin@cmss.chinamobile.com>,
        gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] usb: phy: tegra: Use IS_ERR() to check and simplify code
Message-ID: <20200924102139.GF2483160@ulmo>
References: <20200910115607.11392-1-tangbin@cmss.chinamobile.com>
 <87imc3eiug.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="f61P+fpdnY2FZS1u"
Content-Disposition: inline
In-Reply-To: <87imc3eiug.fsf@kernel.org>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--f61P+fpdnY2FZS1u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 24, 2020 at 10:26:15AM +0300, Felipe Balbi wrote:
> Tang Bin <tangbin@cmss.chinamobile.com> writes:
>=20
> > Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to
> > simplify code, avoid redundant judgements.
> >
> > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>=20
> Applied for next merge window. Make sure to get this driver out of
> drivers/usb/phy and moved into drivers/phy ASAP.

Sergei had commented on this patch with valid concerns, see here in case
you don't have his reply in your inbox:

    http://patchwork.ozlabs.org/project/linux-tegra/patch/20200910115607.11=
392-1-tangbin@cmss.chinamobile.com/#2526208

I agree with those concerns. This patch is broken because it will output
the wrong error code on failure. I don't fully agree with Sergei's point
that this patch isn't worth redoing. I do like the idiomatic error
handling better, but I think we shouldn't be breaking the error messages
like this.

Thierry

--f61P+fpdnY2FZS1u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl9sczMACgkQ3SOs138+
s6Fl0w//W0lviwOWICGtlYukVhARQtGJ/GQCFz2gLD1NWsmrnfdCuN868rubQfyF
DNj6B7RShzGs9SWzKRfmL9IeOp2TZ30YbjOSHNYqGaErbuj2p0sXuqoSF0fg5aRq
2Sp9G6uJSgmOZDPZvWsI4s5UEt58um+LM9zsROCG5y5rQGkSSWdROp7xY0yDy+0T
s06ufbcZqLTTwbxHI00kNeHTurdDhhzP3LZpXHUYs39ge7oArp/g3a0JaxnnFN4g
bTE1o5LA5mYKN6fSgNH7C08bkrJu7GKpoocjPlCbuv8seoDCtGE3q0y07zJo+Mlh
h3hp6t7xGzO+QNfOgEoHwadLDhXq/2+ycAKMf/mmmsadzeILc2uWC3qRxSEuP/Pd
ghj/01b4o4aEPqfbbc0+x5+YYpcOZuyTxVz77VZljgw2e09iAdBhpQ18ssA/O9Tw
dw/+zPMpz9rpHBV/RWnO0i/01sDST3M7T8odcfcScoUeM6HMgMqtAf2LFxldflf8
69CeZOFfdzCyZGYU4QNn1cRzU36/VaJ8voOkcIagzUM8oZYylxvDlhviT5RFr1kf
Wxt9+Bl2CmnzIwAMI5MKln6i3bDndFYCn99eoJ5mk2o82PrgZgdCIRDaY2dJ4h1t
v/SBOkjnksCkxlnWPfHN67VpridtIb4ZrBdh7ZEenz7xXEi8dE8=
=gIrU
-----END PGP SIGNATURE-----

--f61P+fpdnY2FZS1u--