Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp196881pxk;
        Thu, 24 Sep 2020 03:25:47 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzcfYArNV7sfyCuLTlaaxQ/ZrnLqXn4NsKKwpjJAtX+HrAbn/m+Ig29otQdsq3L1oJ8JpLd
X-Received: by 2002:a17:906:c8d2:: with SMTP id gc18mr230433ejb.467.1600943146804;
        Thu, 24 Sep 2020 03:25:46 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1600943146; cv=none;
        d=google.com; s=arc-20160816;
        b=0I4bdPgQ64MkJapQ83h3VAV2cLj1DsalqdH+E3tCflp9RM2MpKvRUZP2O88dgA7GRb
         uYwVlA8WOzu1clfwbm5UsAUcWQ/5s2X/02vuBpn+JXE+uB+RRzV65RBfz7W7rqoXPWQT
         5H4yIzf4ctf/NTSHidaUZvcHeCoNg4dcV2ET+sYNwCrUUfym9J+ViqTSsJ3uEckb7HWq
         9LkHZQf0aPNGZAqYuf5BKbGUVRa0U6pgwjd7W9w9sPiqhGA7nVmzs4q6bZxfOc/IwY6A
         XU6xmsL0bbULO2fVp+WFfMdltxsu4XyHnn/VyF/GiWs4JWDgCBYXpJuH8J23VDgivMY+
         c9bA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=xFEXTrh+NFdeK1/P8HCH4+uK/KDiUSTWNwiqN+Dfnco=;
        b=gKafQxdUKJXogCLH230ojVULrPAAv3rcSo5Ym4vfdDeCmI4IG6K0pFkTCLnYosQp9v
         BgbHaUORrGWNb0FJqPhO79t/jgy9CsCmpR/HoTjfpk8K95KCgcfA8DlmbOxHrz6sArj2
         uVIg6lkDTM2C1b4Qkb645Js/Z40izcptYHi3bZ8/D191njCFuNt2CTIY0xC56D+GKwkd
         JECVmLy7lLPaNZ042NRgkDB8LWs7aHDJUJvTBc+VdB1UO0Q+q9WfhVz7KwM1yAKgNzav
         9KpBTo8TdNyqiAVwQ1Ap+E0N0rg5U+eAaVLEz+oGb4PGGQC/hjq+mn6CfFZ922JgkEUB
         030A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Z6aKkXsq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d16si1662133ejc.620.2020.09.24.03.25.23;
        Thu, 24 Sep 2020 03:25:46 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Z6aKkXsq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727417AbgIXKYU (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Thu, 24 Sep 2020 06:24:20 -0400
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:17189 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727089AbgIXKYU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Sep 2020 06:24:20 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f6c73740000>; Thu, 24 Sep 2020 03:22:44 -0700
Received: from mtl-vdi-166.wap.labs.mlnx (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 24 Sep
 2020 10:24:17 +0000
Date:   Thu, 24 Sep 2020 13:24:13 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     "Michael S. Tsirkin" <mst@redhat.com>
CC:     Leon Romanovsky <leonro@nvidia.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <virtualization@lists.linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jason Wang <jasowang@redhat.com>,
        Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build
 errors
Message-ID: <20200924102413.GD170403@mtl-vdi-166.wap.labs.mlnx>
References: <73f7e48b-8d16-6b20-07d3-41dee0e3d3bd@infradead.org>
 <20200918082245.GP869610@unreal>
 <20200924052932-mutt-send-email-mst@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20200924052932-mutt-send-email-mst@kernel.org>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1600942964; bh=xFEXTrh+NFdeK1/P8HCH4+uK/KDiUSTWNwiqN+Dfnco=;
        h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version:
         Content-Type:Content-Disposition:In-Reply-To:User-Agent:
         X-Originating-IP:X-ClientProxiedBy;
        b=Z6aKkXsqj6CePgZSTh5BKLnR3ekfwpY1807/Dnnp5tf+EovMIDHB+hGzJBrJuHNF6
         6hi5AG4mRMBN2WBVwPfVNe7p4Qwzz++whYxjyt4w/+wqp+Wtu0IKEOaHGunw34otQQ
         SAqByaskjPdhWMiu/1bYh/zdv4WjAmDL/ZBeF5szOK+wKQS3GLEuONnY343PlmU5A2
         B2TzYzjPsYgUWgqLsvBAmgrPDnPp1RSfjQqR+jWAJPmxYTyFvNXsMrNf/nBmVXoEbd
         78iGy79noz7Ey2hRR2IvNh+UbH5y94Mm8aHUKdU+vIFKF1N6peBQHjImumvZIksdhl
         2UI97+VI86Kwg==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
> > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > > @@ -31,7 +31,7 @@ config IFCVF
> > >
> > >  config MLX5_VDPA
> > >  	bool "MLX5 VDPA support library for ConnectX devices"
> > > -	depends on MLX5_CORE
> > > +	depends on VHOST_IOTLB && MLX5_CORE
> > >  	default n
> > 
> > While we are here, can anyone who apply this patch delete the "default n" line?
> > It is by default "n".

I can do that

> > 
> > Thanks
> 
> Hmm other drivers select VHOST_IOTLB, why not do the same?

I can't see another driver doing that. Perhaps I can set dependency on
VHOST which by itself depends on VHOST_IOTLB?
> 
> 
> > >  	help
> > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > >
>