Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Tang Bin <tangbin@cmss.chinamobile.com>,
        gregkh@linuxfoundation.org, jonathanh@nvidia.com,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] usb: phy: tegra: Use IS_ERR() to check and simplify code
In-Reply-To: <20200924102139.GF2483160@ulmo>
References: <20200910115607.11392-1-tangbin@cmss.chinamobile.com>
 <87imc3eiug.fsf@kernel.org> <20200924102139.GF2483160@ulmo>
Date:   Thu, 24 Sep 2020 13:37:17 +0300
Message-ID: <87pn6bcvfm.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Thierry Reding <thierry.reding@gmail.com> writes:

> On Thu, Sep 24, 2020 at 10:26:15AM +0300, Felipe Balbi wrote:
>> Tang Bin <tangbin@cmss.chinamobile.com> writes:
>>=20
>> > Use IS_ERR() and PTR_ERR() instead of PTR_ERR_OR_ZERO() to
>> > simplify code, avoid redundant judgements.
>> >
>> > Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
>> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>>=20
>> Applied for next merge window. Make sure to get this driver out of
>> drivers/usb/phy and moved into drivers/phy ASAP.
>
> Sergei had commented on this patch with valid concerns, see here in case
> you don't have his reply in your inbox:
>
>     http://patchwork.ozlabs.org/project/linux-tegra/patch/20200910115607.=
11392-1-tangbin@cmss.chinamobile.com/#2526208
>
> I agree with those concerns. This patch is broken because it will output
> the wrong error code on failure. I don't fully agree with Sergei's point
> that this patch isn't worth redoing. I do like the idiomatic error
> handling better, but I think we shouldn't be breaking the error messages
> like this.

Sure thing, dropped for now.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEElLzh7wn96CXwjh2IzL64meEamQYFAl9sdt0RHGJhbGJpQGtl
cm5lbC5vcmcACgkQzL64meEamQbZCg/+ImSwyaEYV6RDMjwOS5MSrkEXEUjxOfUU
8I3U0ehVCPiI7lOc9uWUn0QtLxN6/MSvfRxYLaSxc0w3LAIHHYWr4i07PowIEz5b
FdCPzcsqYtkfsr20ENpoz78l90579YbVu+eXfwcmxtXTR/0btQTAhTrsdDQC/LaC
epJgNBEJgsPN08JRPb0fdBBSehsdcul+JlRnBsx3PklwrAoX/nHMTM1x4fiboMHQ
IlN7Qug6E8xLK/+0z995a6Sg9nZeyZMX57kx11tQiZcJ14xG7PfQGz0eeqKiujna
bkgcxfe13hTQELFLM7oqhp/EBG5MibwjrN7Ez5tB1CeCc5916YCKZn6m7VUwgnTB
yCTo7lQ97WAlJg7tQdcFO7kwCS+s6CF+qJ/Fh4rEpv1P+DprQx9Fk7mSw/7IoLTW
fbRcGiKoREfMOJUAxFU7bNeYLQawqVUB2ykPIdlBzDGLZdysCGhgd3cbZwaSCNMT
Q3/Y5vo6FcNkm4lfmzGG00z+j346ObVq3DSne4JBEuEYPqp5/i3N32UpoBSfhoJ9
ukySrGgzMlt5w8cSgWVEvAv/kDWB0dxIdd2eXN53C2+Fvj1C6I7LvAQWc5pcLpxP
6zKyZFUx/XoB6/Wa+wuCuD7ZX21svVcgjJl9QEC/wdHLe08CMelglZuHrzMLEnNC
2O8JUY5b9q4=
=lCLm
-----END PGP SIGNATURE-----
--=-=-=--