Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030253AbWHDEad (ORCPT ); Fri, 4 Aug 2006 00:30:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030259AbWHDEad (ORCPT ); Fri, 4 Aug 2006 00:30:33 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:31922 "EHLO fgwmail7.fujitsu.co.jp") by vger.kernel.org with ESMTP id S1030253AbWHDEac (ORCPT ); Fri, 4 Aug 2006 00:30:32 -0400 Date: Fri, 4 Aug 2006 13:32:10 +0900 From: KAMEZAWA Hiroyuki To: kmannth@us.ibm.com Cc: linux-kernel@vger.kernel.org, lhms-devel@lists.sourceforge.net, y-goto@jp.fujitsu.com, akpm@osdl.org Subject: Re: [PATCH] memory hotadd fixes [4/5] avoid check in acpi Message-Id: <20060804133210.fffaa276.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <1154665534.5925.98.camel@keithlap> References: <20060803123604.0f909208.kamezawa.hiroyu@jp.fujitsu.com> <1154650396.5925.49.camel@keithlap> <20060804094443.c6f09de6.kamezawa.hiroyu@jp.fujitsu.com> <1154656472.5925.71.camel@keithlap> <20060804111550.ab30fc15.kamezawa.hiroyu@jp.fujitsu.com> <1154660408.5925.79.camel@keithlap> <20060804121308.e9720b49.kamezawa.hiroyu@jp.fujitsu.com> <1154661826.5925.92.camel@keithlap> <20060804124847.610791b5.kamezawa.hiroyu@jp.fujitsu.com> <1154665534.5925.98.camel@keithlap> Organization: Fujitsu X-Mailer: Sylpheed version 2.2.0 (GTK+ 2.6.10; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 39 On Thu, 03 Aug 2006 21:25:34 -0700 keith mannthey wrote: > On Fri, 2006-08-04 at 12:48 +0900, KAMEZAWA Hiroyuki wrote: > > On Thu, 03 Aug 2006 20:23:46 -0700 > > keith mannthey wrote: > > > > > > What keeps 0xa0000000 to 0xa1000000 from being re-onlined by a bad call > > > > > to add_memory? > > > > > > > > Usual sparsemem's add_memory() checks whether there are sections in > > > > sparse_add_one_section(). then add_pages() returns -EEXIST (nothing to do). > > > > And ioresouce collision check will finally find collision because 0-0xbffffff > > > > resource will conflict with 0xa0000000 to 0xa10000000 area. > > > > But, x86_64 's (not sparsemem) add_pages() doen't do collision check, so it panics. > > > > > > I have paniced with your 5 patches while doing SPARSMEM.... I think > > > your 6th patch address the issues I was seeing. > > > > > > with the 6 patches things work as expected. It is nice to have the > sysfs devices online the correct amount of memory. > > I was broken without this patch because invalid add_memory calls are > made on by box (yet another issue) during boot. > > I will build my patch set on top of your 6 patches. > Okay, thank you very much ! -Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/