Date: Thu, 3 Aug 2006 22:22:04 -0700
From: Andrew Morton <akpm@osdl.org>
To: "Nate Diller" <nate.diller@gmail.com>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] [2/3] add list_merge to list.h
Message-Id: <20060803222204.f369e6da.akpm@osdl.org>
In-Reply-To: <5c49b0ed0608031915g2c1fc44ch623a7657b994bf9c@mail.gmail.com>
References: <5c49b0ed0608031915g2c1fc44ch623a7657b994bf9c@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1195
Lines: 39

On Thu, 3 Aug 2006 19:15:15 -0700
"Nate Diller" <nate.diller@gmail.com> wrote:

> +/**
> + * list_merge - merge two headless lists
> + * @list: the new list to merge.
> + * @head: the place to add it in the first list.
> + *
> + * This is similar to list_splice(), except it merges every item onto @list,
> + * not excluding @head itself.  It is a noop if @head already immediately
> + * preceeds @list.

"precedes"

> + */
> +static inline void list_merge(struct list_head *list, struct list_head *head)
> +{
> +	struct list_head *last = list->prev;
> +	struct list_head *at = head->next;
> +
> +	list->prev = head;
> +	head->next = list;
> +
> +	last->next = at;
> +	at->prev = last;
> +}

Interesting.  I didn't realise that none of the existing functions could do
this.  I wonder if we can flesh the comment out a bit: define "headless" a
little more verbosely.

Should we call it list_splice_headless() or something?  list_merge is a bit
vague.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/