Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp275746pxk; Thu, 24 Sep 2020 05:35:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmmKZxVuaqLhesUAyIWqBzgE4bO+i833AZ4/pA3WgtGJq60t6Do4NqUNpk50AeFAPm/15U X-Received: by 2002:a17:907:7215:: with SMTP id dr21mr758152ejc.239.1600950913161; Thu, 24 Sep 2020 05:35:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600950913; cv=none; d=google.com; s=arc-20160816; b=dQ/+JjQ+DBj/CB3xZ/cy9ijFuAnfKU6fkRvfBXR54g5UJ2DeE9WNssa81Fewsf/SRN HaeVWreZiYRpXLGx2Fono7vYjCByQyzejb5YfEzUMyt3KCW3qIkiZdRRsFw5lw6nlmWH dSg8TNgL8fd+JCjUllvvdmoc9b0lOkKj5ilNTNKpvyPswBef04Hpj72Pir6c6zRB58sA KldhoPRbLbn5HNJ6mQ5jcaS9Wr+HcHFd3xLUlLoWvmPqVee6Rn3NC0gPMQzl4xw9Z0kJ H5I0nBtypEXvFQf0M/JIT341vTNTNQ72IibacrJsETTgwyXSFScy21WMmlQ3kgHrA8IS 4lsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=5z81b0l/ou8a1NGQIAUTYGK50fEsB6aV5MR6+jiqW8U=; b=K3+Izyzrz3lGy1mG/S9pfSLEZluwL1YnmtSJoPLhkLh/q25Hu66R4CU271tMKuwJIP OsL2xWEN07p9++Ok3Of7elMnMA1oX6DI1FDVfFScFpHWY3IBFy5lWbEpCe5JRWC1dJPK kRlIZnoW04FcfxqtftcsnP3BNzO/J872RmEymmaMiuIJLmehxi0AkFR7tuh8vhJqO1zE 8dYjbYgqOcAneESmHIpQ2YnX3pdsOhLIr7F/b/uZfevTSE6NOr4gJ13P97sBHeBsDFr2 QTYF6/5yqUvMMzMZdkv30OgkkqtMhBmvISOyvxLX3r6vA3CHPEoOKSddR6H4yZWKdnl/ rHkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=V6bjnZoo; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z14si1761645eja.502.2020.09.24.05.34.49; Thu, 24 Sep 2020 05:35:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=V6bjnZoo; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbgIXMba (ORCPT + 99 others); Thu, 24 Sep 2020 08:31:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727570AbgIXMba (ORCPT ); Thu, 24 Sep 2020 08:31:30 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00489C0613CE for ; Thu, 24 Sep 2020 05:31:29 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1600950688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5z81b0l/ou8a1NGQIAUTYGK50fEsB6aV5MR6+jiqW8U=; b=V6bjnZooJtr1WM7nDsx5fWI6vLi1VItA1R8bQtqGIu+sXQ4Lmo1QTicCjetO8yhFWKz7O2 ZiyxJ7kdRoqONsYfpj72YajZE7muZGfmTGOxu37qF1Du0YJxyIAEko8xLvyart5pZfPlxC UD0fi2YmXJxL1XEEmOvGnXCznP8eivd0qi8/A9PqC5yA1wd26FOIZczlhyYRNfMYfbgHD5 UvoO4oEhZVuqmtoNBpiuhSKczs3X04WKeLjZH6Y3Ud2xinlZQtfgpenMJFhBZ5p7pD1FgD FhQJJkZ6ht9N76CTz6zDpJjyQj6NQh5bN2ZLzp5iMk+VeamNyvmEjw/FeI7fQg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1600950688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5z81b0l/ou8a1NGQIAUTYGK50fEsB6aV5MR6+jiqW8U=; b=Ix8Ykr+c5+mW05+gua7Jy3Ryh1WB3CFcHLWhygzt0KwubfPERGmDX2CXFuy37l3gLFjXGB B0hmn48tl7KeyBDQ== To: qianjun.kernel@gmail.com, peterz@infradead.org, will@kernel.org, luto@kernel.org, linux-kernel@vger.kernel.org Cc: laoar.shao@gmail.com, qais.yousef@arm.com, urezki@gmail.com, jun qian Subject: Re: [PATCH V7 2/4] softirq: Factor loop termination condition In-Reply-To: <87v9g38tcc.fsf@nanos.tec.linutronix.de> References: <20200915115609.85106-1-qianjun.kernel@gmail.com> <20200915115609.85106-3-qianjun.kernel@gmail.com> <87v9g38tcc.fsf@nanos.tec.linutronix.de> Date: Thu, 24 Sep 2020 14:31:27 +0200 Message-ID: <87r1qr8ig0.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24 2020 at 10:36, Thomas Gleixner wrote: > On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: >> asmlinkage __visible void __softirq_entry __do_softirq(void) >> { >> u64 start = sched_clock(); >> unsigned long old_flags = current->flags; >> - int max_restart = MAX_SOFTIRQ_RESTART; >> + unsigned int max_restart = MAX_SOFTIRQ_RESTART; > > And this change is related to making the timeout check a function in > which way? Aside of that looking at: https://lore.kernel.org/r/20200911155555.GX2674@hirez.programming.kicks-ass.net Peter gave you a series of patches, granted they are untested and lacking proper changelogs. But you go and repost them mostly unmodified and taking authorship of them. This not the way it works. You cannot claim authorship of something you did not write yourself. See Documentation/process/ for detailed explanation how to handle patches which you got from someone else. Thanks, tglx