Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] net: dsa: mt7530: Add some return-value checks
To:     Landen Chao <landen.chao@mediatek.com>
Cc:     Sean Wang <Sean.Wang@mediatek.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1600327978.11746.22.camel@mtksdccf07>
 <20200919192809.29120-1-alex.dewar90@gmail.com>
 <1600949604.11746.27.camel@mtksdccf07>
From:   Alex Dewar <alex.dewar90@gmail.com>
Message-ID: <9db38be8-9926-b74b-c860-018486b17f3a@gmail.com>
Date:   Thu, 24 Sep 2020 14:11:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <1600949604.11746.27.camel@mtksdccf07>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2020-09-24 13:13, Landen Chao wrote:
> Hi Alex,
>
> Thanks for your patch. By linux/scripts/checkpatch.pl
>
> On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote:
> [..]
>> @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch *ds)
>>   		mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK,
>>   			   PCR_MATRIX_CLR);
>>   
>> -		if (dsa_is_cpu_port(ds, i))
>> -			mt753x_cpu_port_enable(ds, i);
>> -		else
>> +		if (dsa_is_cpu_port(ds, i)) {
>> +			ret = mt753x_cpu_port_enable(ds, i);
>> +			if (ret)
>> +				return ret;
>> +		} else
>>   			mt7530_port_disable(ds, i);
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Unbalanced braces around else statement
>>   
>>   		/* Enable consistent egress tag */
>> @@ -1785,9 +1791,11 @@ mt7531_setup(struct dsa_switch *ds)
>>   
>>   		mt7530_set(priv, MT7531_DBG_CNT(i), MT7531_DIS_CLR);
>>   
>> -		if (dsa_is_cpu_port(ds, i))
>> -			mt753x_cpu_port_enable(ds, i);
>> -		else
>> +		if (dsa_is_cpu_port(ds, i)) {
>> +			ret = mt753x_cpu_port_enable(ds, i);
>> +			if (ret)
>> +				return ret;
>> +		} else
>>   			mt7530_port_disable(ds, i);
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Unbalanced braces around else statement
>
> [..]
> regards landen
Hi Landen,

Sorry about this... I usually run checkpatch over my patches. Would you 
like me to send a separate fix or a v3?

Best,
Alex