Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp327726pxk; Thu, 24 Sep 2020 06:42:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuhzH6LBAhqYewtkBnqUvWOX1EKh5w7+t6bHloirMYouydt9SGYKcOnVNSSV4EYSb74cAT X-Received: by 2002:a17:906:a156:: with SMTP id bu22mr1139606ejb.177.1600954928723; Thu, 24 Sep 2020 06:42:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600954928; cv=none; d=google.com; s=arc-20160816; b=woXjNFYQ2wYkfOlZ9rsjU4Q79x7qZjW2zA0QDJvUQ/Hmb+oNs3itdNfd8LLJeexb7m +i9a/UiZvQGEqvB2hLR7tYTWRuC04Vf5XJGEHEMPWvTZfeL34zCg4mWHq5ip9OI+OZUo jwnEHq940U7nsZskNnaVRPNHlsxuX+2nE4k0MbuVefXNnLB4YRer8xuGwBFIksEw1jQG bPQaaTN2C1nPgdD+37xjOfOrbDk31irJ8k6m+7YLo7VBqM03W2Ms84ubFX7jn7CwJgOB G/CwOPhuWGncJ5urUVDJGqrpUcAYVUILb446KShYzDfg3iRDSYBy5apZPXxNyAqtutct 5teA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cGJ/OdtZht+9heWoI2epD1dIdA+gcxLBdCbKRQuv3zI=; b=LU+RcFWLLrpcDwJJYp26nsDvRmxuEnHL49ktlb7oYQ5AiKO8a0P1xSwy83gjLDK+rY TBHa5F0ENraLc/8J6u4/0YS/geOEXqz0tYQJ3HNRmHSJ34SnCMe9Rt6EoqQyLJAIDTTu GC+h0JImmTFXXkOfSBd/wi1wetRuKfAzxctjwwEcQVnfYjnSSVwrAfUo4IBHBWdrHlcY wxd91NTKv8Pq/81+erOhV4MBxXUQMmr+x1CfMRWbwixliO79Cl0qf2RJ37bdOnPi39aM CG0DM+YaPh8AFkuaJEOgDo7WU9qqLdKQlE0PcpnTGBKTsvo5z5+B3u8utqyyJ20Z1Zx/ S52g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d5Sgm2ZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bk4si1952542ejb.215.2020.09.24.06.41.45; Thu, 24 Sep 2020 06:42:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d5Sgm2ZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727993AbgIXNkb (ORCPT + 99 others); Thu, 24 Sep 2020 09:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbgIXNka (ORCPT ); Thu, 24 Sep 2020 09:40:30 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1E4BC0613CE; Thu, 24 Sep 2020 06:40:30 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id y6so1684200plt.9; Thu, 24 Sep 2020 06:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cGJ/OdtZht+9heWoI2epD1dIdA+gcxLBdCbKRQuv3zI=; b=d5Sgm2ZR1hnM76gGIOud2fuXPBUPd68NCmYXPCjIrec51wvWiCTYtuxSawzakRYRI6 yxtPKuh/79mhucoh5rcviIifiCNBK/TGT8/0DVv3Dkv+c31sq65SY8ZuYgmuEVNLWD1y 6453nNl32aQ1GY8PJtwdfr/xuRpY5POSO88zVTEUjKGN7/uczSIsLmTdPVyoh8YNmbsL C7wK5CNsVD4XOkQycag1rT2KFugOz2LHQopMT40bcwGPuypybsVDTBtL0wpXGeG2rqKI zRmuLRfj0HtIM1RS6i/X2SaH2is4BmjdtM2jKsku9Cu2OxRINCkOuvCs31nJlmVdNoDD mGkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cGJ/OdtZht+9heWoI2epD1dIdA+gcxLBdCbKRQuv3zI=; b=rIQwnn6J/92rYcuBuGjQnA+1n9HMCJtDYMaZdi/3m0WE9rs3PayB6vVbAMO7b4f9GE YIG8JqGboegoT3TWNmGqzC1RyphlkB4hRTAfneTOXi8rhkd1BUU0O4YDREeoDZPce0Tm zEtiHYPwx1xwaHDiA4tapl5YXgH8tgF4mTNKOie6eptpu2jXNvtkE8F/F1Beao3Nshd/ vGM1UyDyptImKMdkdAP623PrQnIGU7z9ADYu8KL3vIpMVGmBBrLWm9qnr562WuXVDW+d tDEt2VAurPdUmVEXRYQA/olavrPZg7CPHJBbkCdr8IxwRPuH/F5wJBdYAy7m1CEsKbwA z40Q== X-Gm-Message-State: AOAM530qCnUupNhTArKYxF1JG3Z8JamiC9OFXBpdX97fDX46SB7jm4tb 4IBekmdUrj1gcbD7hqghnSnIPlJl3ZFyWA== X-Received: by 2002:a17:902:aa95:b029:d2:19f4:ff56 with SMTP id d21-20020a170902aa95b02900d219f4ff56mr4694395plr.78.1600954830270; Thu, 24 Sep 2020 06:40:30 -0700 (PDT) Received: from sol (106-69-189-59.dyn.iinet.net.au. [106.69.189.59]) by smtp.gmail.com with ESMTPSA id u71sm3046759pfc.43.2020.09.24.06.40.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:40:29 -0700 (PDT) Date: Thu, 24 Sep 2020 21:40:24 +0800 From: Kent Gibson To: Bartosz Golaszewski Cc: Andy Shevchenko , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Linus Walleij Subject: Re: [PATCH v7 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Message-ID: <20200924134024.GA239773@sol> References: <20200905133549.24606-1-warthog618@gmail.com> <20200905133549.24606-8-warthog618@gmail.com> <20200920111204.GB793608@sol> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 03:36:24PM +0200, Bartosz Golaszewski wrote: > On Sun, Sep 20, 2020 at 1:12 PM Kent Gibson wrote: > > > > > > > > Can we use static_assert() at the top of the file? Presumably after > > > inclusion block. > > > > > > > Good idea - will do. > > Thanks Andy for bringing this to my attention, the amount of kernel > interfaces I still don't know after all these years still amazes me. > And don't forget it was originally Andy's idea to use the BUILD_BUG_ON() as well ;-). Cheers, Kent.