Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp426269pxk; Thu, 24 Sep 2020 08:54:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPF6BUwT6/8NIch36SWxq97ULiMVjia/bA0Z53EFWBSJMIhNcZfLT8t9miwrC2BlHHTP7O X-Received: by 2002:a17:906:a985:: with SMTP id jr5mr520378ejb.549.1600962899604; Thu, 24 Sep 2020 08:54:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600962899; cv=none; d=google.com; s=arc-20160816; b=TZj1okF61NIUO/eAEl73Wvu3llZ16vdjLCWkXkYrz6uv/rAyRnFu2H7QFcum4K9JDo Nwt81gcuKwOJkIZVO8B3UilxS39xyU3zAIKzoLze+ulsWgvRFdj57gwFtotZgHpIXFGS lXxEqqSkVndLiyhlyTVV6Wq7hklVYql7tuwEFRyWHFKwbJ7ey9cXHR3Dk11B6EsWuS6Q NduT4xumqkGokeX3kUGahj7XfNnudfWGRBW9v+gNK8zyhB7BUt4EKiFZmgICYjFDhvLI b2KGmTFvcr9P69a5s6ho5/chbBGMnzcox0lb6EtcUJpGhym//tc4ZuzNad4Yt99d9fKC Ln5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=vPj5HUHK1sveLhinkO2rrNMbTgOHpcSG/Qgh39xMlGk=; b=IktFwEUcexL/CBIsX85nyWHiHjNpvkHpanTboOjYbNsb3mw/N8HpoC2SlpvYnTo9ZA otxaEo7YwZr1bQrBepr6gPcT+X4qwKX2Z3QsVnF9kTglXmq9WYe+bu1Omz8de2mS1Xtg jkEZIaJiHJNfHo8zUtA6L+Suyaqgn1uHQVthFM4ZdZhFjZYpeGXSbIOm8n8G2s54rZCv 6lL2RQnaE+0jiDsHdnXacaL3crDBS47flJhP2k4aFj1Eh6PVp+WU9AoDTXckWsyOpBW4 SF4lVMr+eBRsqhE1Itun1e0HYXUXC99wkXHHyyCL7+ewg2zN278FDGve/x1P1Ne+z0KJ lM8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=iehH+Ovn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si2087586ejq.644.2020.09.24.08.54.34; Thu, 24 Sep 2020 08:54:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=iehH+Ovn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728515AbgIXPwJ (ORCPT + 99 others); Thu, 24 Sep 2020 11:52:09 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:45130 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728285AbgIXPwI (ORCPT ); Thu, 24 Sep 2020 11:52:08 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08OFZ1hm158198; Thu, 24 Sep 2020 15:51:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=vPj5HUHK1sveLhinkO2rrNMbTgOHpcSG/Qgh39xMlGk=; b=iehH+OvnhOP4xunxBiWDwJl2tVgSMeneguI6LEzqTnboYBhn8AWWBseqRFc2zq4/m/54 UM+ayvNJBXUE5JNyPGLXukWuHVDQ3qORJtdLN6KbwjrxzyKY/4SZ38VTgsp7dAIkY5C6 /LZP39sv5Pjdf0lTAVJshlT4T1LAnFsUBQZJQjzjVHRjToI6kufzXjzanL70Oz/adSHN cDwdxQRR9mh0SKHTJJYf9LtsYKFLHJfwIanK0JUt72ao9w6ZBvcldPmXJdRp2HyjX1/J ZEp31Gk93HSQgvp17OAVeX358nlEJN4npJyl3CkR8O3iIQj08lUWyf0+zMdcBbAQV4bx Lw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 33ndnus5vv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 24 Sep 2020 15:51:32 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08OFVSmU126417; Thu, 24 Sep 2020 15:51:31 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 33nux2yuk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Sep 2020 15:51:31 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08OFpSHu001507; Thu, 24 Sep 2020 15:51:29 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 24 Sep 2020 08:51:28 -0700 To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Coly Li , Richard Weinberger , Minchan Kim , Johannes Thumshirn , Justin Sanders , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@tron.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Jan Kara Subject: Re: [PATCH 04/13] aoe: set an optimal I/O size From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200924065140.726436-1-hch@lst.de> <20200924065140.726436-5-hch@lst.de> Date: Thu, 24 Sep 2020 11:51:24 -0400 In-Reply-To: <20200924065140.726436-5-hch@lst.de> (Christoph Hellwig's message of "Thu, 24 Sep 2020 08:51:31 +0200") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9753 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009240118 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9753 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 adultscore=0 suspectscore=1 bulkscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009240118 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > aoe forces a larger readahead size, but any reason to do larger I/O is > not limited to readahead. Also set the optimal I/O size, and remove > the local constants in favor of just using SZ_2G. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering