Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp431841pxk; Thu, 24 Sep 2020 09:02:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBf/TsVzzlpDa+DcX4PeotqZFkqpQ1wTnQLkEZhN2Qw9SNKgPxR7vLrPabk2zG7ipkcOJ7 X-Received: by 2002:aa7:d059:: with SMTP id n25mr619270edo.270.1600963353205; Thu, 24 Sep 2020 09:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600963353; cv=none; d=google.com; s=arc-20160816; b=IMdfq0wQ2mto//uVEvK8Yc9HaFZjJ3ZR496IjgpGNmRlq62UtSNyKmP8kLCZ/WFCYj RWZUtQOscDsJgqQbWS5gXxF1VbjtKeKOmV2YjlA9bCDU/d9ksL9JZw1+4wR/6o14Ipqs QDoRoxUPvaiS+Ns7Tki9hgtNE+Rtq13EL+msS1bJC1pxE15pu0dNSP5EDRZlSm6pRyhn aMmaTqpg1sOnbELu05w3qUxpfYhNra1C8HXeTHvQFixxdyQbmQCx6Ubos/tJzyeCV85L Axv8Q/SpmFQl3XwUXBD/b1W4DNvBmeurXvwhbpM1vkAW+A7oLZGL5FYP7lFqMOwRqAuf wvEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FXcD1GzQb3LhU2FMsXpaXadKoVZASqPUcYb0QsB0JoA=; b=SIN/Qe9Iq0JQi3TrX0usNpUJAKCRAkxOVWvUmqmbvTNUJvkTT4snxp6RNP0vBrLKz8 yom7z82n0VG0LAhZQZDQHyzGCoguXvVOMluboa+baLOU2H16Twnr9tbWDeUeS75Rxbbd WtS9brEfZ5Dh4L1hCV5YgFszWR8GkGl6r4/MOlZjF0XkDLD5nIh3zwHlK4UXGX4VAYmk SP9oLERtXdvIClAfFofGGl1ytzpAscRhmU2KGx5SxcGx4vvgeUbcRclsA9lYstjyAo1f Mi+SNX7MOdA4Fh1myaTgOP4mssDbiurmRUfcB8Kc3NskTdVT/swj65UDSCTmWSgJUSyr u2+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AwScAfRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si2438224ejr.667.2020.09.24.09.02.07; Thu, 24 Sep 2020 09:02:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AwScAfRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728549AbgIXQAv (ORCPT + 99 others); Thu, 24 Sep 2020 12:00:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:32952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbgIXQAv (ORCPT ); Thu, 24 Sep 2020 12:00:51 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6ADA3235FD; Thu, 24 Sep 2020 16:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600963251; bh=r67kiC0WjaNVmOhYLjf6JYjUJqRLU6Z2/EyBhfyzyvU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AwScAfRx9Njhn+CsDf0vIPl1vMTCryCGmJiCCir1LBP2pGPpRObRPiwsIoyRYH6N/ xUCfZrh4aCjPZwNIHlxf0aMfv2SW539VKPcmv4ErcMaOcXInPHNESLWt4RHU02/Yyp fForhBgGlJDyPOtPYa/UHZ89hPiCuqNi9WgX4ljA= Date: Thu, 24 Sep 2020 18:01:07 +0200 From: Greg KH To: Petko Manolov Cc: Oliver Neukum , Himadri Pandya , davem@davemloft.net, kuba@kernel.org, pankaj.laxminarayan.bharadiya@intel.com, keescook@chromium.org, yuehaibing@huawei.com, ogiannou@gmail.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 3/4] net: usb: rtl8150: use usb_control_msg_recv() and usb_control_msg_send() Message-ID: <20200924160107.GA1174357@kroah.com> References: <20200923090519.361-1-himadrispandya@gmail.com> <20200923090519.361-4-himadrispandya@gmail.com> <1600856557.26851.6.camel@suse.com> <20200923144832.GA11151@karbon> <2f997848ed05c1f060125f7567f6bc3fae7410bb.camel@suse.com> <20200924154026.GA9761@carbon.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924154026.GA9761@carbon.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 06:40:26PM +0300, Petko Manolov wrote: > On 20-09-24 13:09:05, Oliver Neukum wrote: > > Am Mittwoch, den 23.09.2020, 17:48 +0300 schrieb Petko Manolov: > > > > > One possible fix is to add yet another argument to usb_control_msg_recv(), > > > which would be the GFP_XYZ flag to pass on to kmemdup(). Up to Greg, of > > > course. > > > > submitted. The problem is those usages that are very hard to trace. I'd > > dislike to just slab GFP_NOIO on them for no obvious reason. > > Do you mean you submitted a patch for usb_control_msg_recv() (because i don't > see it on linux-netdev) or i'm reading this all wrong? It's on the linux-usb list: https://lore.kernel.org/r/20200923134348.23862-1-oneukum@suse.com