Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 8/9] surface_aggregator: Add DebugFS interface
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Bla=c5=be_Hrastn?= =?UTF-8?Q?ik?= <blaz@mxxn.io>,
        Dorian Stoll <dorian.stoll@tmsp.io>
References: <20200923151511.3842150-1-luzmaximilian@gmail.com>
 <20200923151511.3842150-9-luzmaximilian@gmail.com>
 <CAK8P3a0=98pzgWwBKddy7BQ9g90ga8JEx=MtADW+aqTe0AVV6w@mail.gmail.com>
 <cfed1f74-653c-565b-ea91-877c4e1f63a0@gmail.com>
 <CAK8P3a0_i=wHnQmfbjCdMgFRSD0eGjEM2uMFft5FJ4M1GSUbHg@mail.gmail.com>
 <5d470a61-bf4d-7ea2-b41f-1163006b1956@gmail.com>
 <CAK8P3a3HWjyaxwN3gyFEcJ9P=iHPvYXsL=C2kEg1hDmJvNm1tQ@mail.gmail.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <043f9a77-784d-e887-19e0-57e42ff6bddc@gmail.com>
Date:   Thu, 24 Sep 2020 20:44:20 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAK8P3a3HWjyaxwN3gyFEcJ9P=iHPvYXsL=C2kEg1hDmJvNm1tQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/24/20 9:41 AM, Arnd Bergmann wrote:
> On Thu, Sep 24, 2020 at 12:23 AM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>> On 9/23/20 8:51 PM, Arnd Bergmann wrote:
>>> On Wed, Sep 23, 2020 at 8:29 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>>>> On 9/23/20 6:48 PM, Arnd Bergmann wrote:
>>>
>>> The version I showed avoids the pointers and is compatible with
>>> 32-bit user space.
>>
>> I'm not completely convinced yet that the read/write approach is the way
>> I want to do it, especially with Greg suggesting a misc device, but I'll
>> keep your solution in mind.
> 
> In case of a character device, I'd go with an ioctl to keep it extensible.
> 
> The read/write based interface is what I'd use in debugfs.

Perfect, thanks!

I'll follow Greg's suggestion and create a misc device, and then go for
the IOCTL interface as you suggest.

Thanks again,
Max