Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp579707pxk; Thu, 24 Sep 2020 12:49:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQ0MuW9n5DI6gaySvUGxOtnBRVNcsuoB4XS7kOToy4JPf/bkfKYJ86NqynxCKS3LRpkaxS X-Received: by 2002:a17:906:660f:: with SMTP id b15mr241171ejp.333.1600976978064; Thu, 24 Sep 2020 12:49:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600976978; cv=none; d=google.com; s=arc-20160816; b=M65b59eHnIw8xcyKWaK8WKowTZrkwCotyTiZdOKYEf583nFc5B7Kb8thJ2YB+fPeE+ tz/ZCmd182pdRhD7WlH0LmjoHD2pqBwGOD5FOYJWn9rp41gU3yOZHTGRkZSLP/G11U5b V/S/dl+lNDq1O85CC1V6YjUwiE/F4pV1ByQwcd7yvbiDnMjqGdLkvO6NYkMe0f+DeqsH QHDZJjd7fDTOmAE/ocEEX5ClEw71RzQ62Jj6YX6tXN6iWO3gTJScHAJVCV3hgYOpaLXl 4FfxflmF1cU/Dg3gdH7tpVcqj8yw1Qif/hWujewvq578FmqIWNLl0rR0yor6LRzgmRQD Igmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=658tPJyYv3egGWM5ylaGSqGvcESSUdksRBvSNe+T9oo=; b=EOcds3/EfC/PH+VDv15FN2BRjiNe8V6dBYGX8dr/qtVpolxKkyRPX7EUrDSCzprj8l k8yZovVb+p+jeAV+D7wGPXeCROwLIYY3wmDde5Uw0YkZbNxfq+TV89ubxUHNL8EIchz8 wKGpEJTFL2SBeh5Q8QO0CsoSNRECnuaMDgWWf4jclCofUOWXSoAIK/werBYcgxRoyXkt 1t2HbjX8btfGNa0gTBXikPtbM88oO8xkpaG2JRe1RwaNKkZzJ0P2//MhOrnMRvN8Kt51 jwYvCpRWw2hcKAJqCpgJxXrwyi3MOA+GluqINYsyf9JoEG0abLPCNSXW8rGPmxshnSjo C71g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si301263edq.91.2020.09.24.12.49.13; Thu, 24 Sep 2020 12:49:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgIXTqJ (ORCPT + 99 others); Thu, 24 Sep 2020 15:46:09 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:50622 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbgIXTqJ (ORCPT ); Thu, 24 Sep 2020 15:46:09 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 687FB20073; Thu, 24 Sep 2020 21:46:07 +0200 (CEST) Date: Thu, 24 Sep 2020 21:46:06 +0200 From: Sam Ravnborg To: Qinglang Miao Cc: Thierry Reding , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/panel: simplify the return expression of td028ttec1_prepare Message-ID: <20200924194606.GB1223313@ravnborg.org> References: <20200921131018.91513-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921131018.91513-1-miaoqinglang@huawei.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=CaYmGojl c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=t2hpYR1j4ttwukXXcmsA:9 a=CjuIK1q_8ugA:10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Qinglang On Mon, Sep 21, 2020 at 09:10:18PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao Thanks, applied to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > index 037c14fd6..ba0c00d1a 100644 > --- a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > +++ b/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > @@ -242,13 +242,8 @@ static int td028ttec1_prepare(struct drm_panel *panel) > static int td028ttec1_enable(struct drm_panel *panel) > { > struct td028ttec1_panel *lcd = to_td028ttec1_device(panel); > - int ret; > > - ret = jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL); > - if (ret) > - return ret; > - > - return 0; > + return jbt_ret_write_0(lcd, JBT_REG_DISPLAY_ON, NULL); > } > > static int td028ttec1_disable(struct drm_panel *panel) > -- > 2.23.0