Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200924200507.1175888-1-mr.nuke.me@gmail.com>
In-Reply-To: <20200924200507.1175888-1-mr.nuke.me@gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 24 Sep 2020 17:22:23 -0300
Message-ID: <CAOMZO5B4S3JCVQAi-y=vKaQv3AF6eXronTkmG_DZs_ALtEHtgA@mail.gmail.com>
Subject: Re: [PATCH 1/2] drm/bridge: sii902x: Enable I/O and core VCC supplies
 if present
To:     Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc:     DRI mailing list <dri-devel@lists.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alexandre,

On Thu, Sep 24, 2020 at 5:16 PM Alexandru Gagniuc <mr.nuke.me@gmail.com> wrote:

> +       ret = regulator_enable(sii902x->cvcc12);
> +       if (ret < 0) {
> +               dev_err(dev, "Failed to enable cvcc12 supply: %d\n", ret);
> +               regulator_disable(sii902x->iovcc);
> +               return PTR_ERR(sii902x->cvcc12);

return ret;

>
>         ret = regmap_write(sii902x->regmap, SII902X_REG_TPI_RQB, 0x0);
> @@ -1012,11 +1052,11 @@ static int sii902x_probe(struct i2c_client *client,
>         regmap_read(sii902x->regmap, SII902X_INT_STATUS, &status);
>         regmap_write(sii902x->regmap, SII902X_INT_STATUS, status);
>
> -       if (client->irq > 0) {
> +       if (sii902x->i2c->irq > 0) {

Unrelated change.

>                 regmap_write(sii902x->regmap, SII902X_INT_ENABLE,
>                              SII902X_HOTPLUG_EVENT);
>
> -               ret = devm_request_threaded_irq(dev, client->irq, NULL,
> +               ret = devm_request_threaded_irq(dev, sii902x->i2c->irq, NULL,

 Unrelated change.
                                                 sii902x_interrupt,
>                                                 IRQF_ONESHOT, dev_name(dev),
>                                                 sii902x);
> @@ -1031,9 +1071,9 @@ static int sii902x_probe(struct i2c_client *client,
>
>         sii902x_audio_codec_init(sii902x, dev);
>
> -       i2c_set_clientdata(client, sii902x);
> +       i2c_set_clientdata(sii902x->i2c, sii902x);

Unrelated change.

> -       sii902x->i2cmux = i2c_mux_alloc(client->adapter, dev,
> +       sii902x->i2cmux = i2c_mux_alloc(sii902x->i2c->adapter, dev,

Unrelated change.