Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp615437pxk; Thu, 24 Sep 2020 13:56:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb3ujyWQl+yad5sUZvf1PnvDGBSrqm+qkqdj8UHRN9JERZKvRmhWT36PBEK0vj4NSNPLiz X-Received: by 2002:a17:907:70cb:: with SMTP id yk11mr493019ejb.312.1600980968676; Thu, 24 Sep 2020 13:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600980968; cv=none; d=google.com; s=arc-20160816; b=zQgwXd5LE+AdQ/xkhc0Mca6+sKAcTbOa/WV3KQb/EeMLzr0TWBQUeu3ejz8Y/OBeai gWxjpw98JhKovXCNx5p1rZvj1W/JTW7CNy8i/Z3xVB16iOmRtsl/hla58CyiX0Gayz0a pzEQfsl8sLr+Qoe3C7m6PpDy90pe63H0GkNns8QoFL97pLH1QLGvYIKdm1WTeU8iNv3U SZweGjBtXSqSIGXO/bUcFojKu4ELU37w+4XD/1G4VC+MIQaQnrlnOb1xcFeSKBmBfi9e UkxeTaTsVsRKRaTxh5TjXsZE/EK4xpA95HaWOXZEVVaVUpPG5f7MV/bpL/IBNuISAowf adCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=i6gNR6HYFGUeVV1/H4ig8UKrhBwaMNsaJWoZfh2Anec=; b=X2fSbGbUHoPmQnL4oKk2vImlxQBySafsNcCwEp557rsosFG8oZA+P7jvoEXCNUuxTi URIsPbabIcL5sytG8/EC1xrWutbPjVVJZbQAPyfQnnZREoGdvDfu1s3B1IztHz7NYzr0 cav/fY7N6TFCMmNS1KFHZiWSPkhnm075udxSC55/WEO+G0/jsDXG6Ng5Ry8LXvvGWySe GsgEprcwsCQeUjCnGKF9MSYgYQ2BlGkMZDJxTPT2xRt9NSwCCs2KhaQxa6yjv3NdklO0 ZlGMl0+p4UJ08ldljid00HP0t/iIqns8LZ6m+xjiniSNhaPEAfTbolgG5axuyeywDVDV n6eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iSnYpDRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u7si353708edo.567.2020.09.24.13.55.44; Thu, 24 Sep 2020 13:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iSnYpDRh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726640AbgIXUyR (ORCPT + 99 others); Thu, 24 Sep 2020 16:54:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:46226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbgIXUyR (ORCPT ); Thu, 24 Sep 2020 16:54:17 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 928AF221EB; Thu, 24 Sep 2020 20:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600980856; bh=tVjYj9L6bZlyfmQII/W2YskHWml8UCyVZRJQUGN3Hew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iSnYpDRhlNSQLE336fF32Fw3x7t7F7vSL4XkGh8Ah/H0Y9tPbXGBZJs0x/j3SqtKA pu6F0VIA+ia1EI+gcsnbPDrAUQO9GPIpyQQdaXVpIk85n7VwtJhn74SfswoKAEdv4+ m7dm/7zkj42sSjYFFleRXcs0C8HBfnxz4uIr8z08= Date: Thu, 24 Sep 2020 16:54:15 -0400 From: Sasha Levin To: Johan Hovold Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.4 041/330] USB: serial: mos7840: fix probe error handling Message-ID: <20200924205415.GQ2431@sasha-vm> References: <20200918020110.2063155-1-sashal@kernel.org> <20200918020110.2063155-41-sashal@kernel.org> <20200918065300.GA21896@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200918065300.GA21896@localhost> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 08:53:00AM +0200, Johan Hovold wrote: >On Thu, Sep 17, 2020 at 09:56:21PM -0400, Sasha Levin wrote: >> From: Johan Hovold >> >> [ Upstream commit 960fbd1ca584a5b4cd818255769769d42bfc6dbe ] >> >> The driver would return success and leave the port structures >> half-initialised if any of the register accesses during probe fails. >> >> This would specifically leave the port control urb unallocated, >> something which could trigger a NULL pointer dereference on interrupt >> events. >> >> Fortunately the interrupt implementation is completely broken and has >> never even been enabled... >> >> Note that the zero-length-enable register write used to set the zle-flag >> for all ports is moved to attach. >> >> Reviewed-by: Greg Kroah-Hartman >> Signed-off-by: Johan Hovold >> Signed-off-by: Sasha Levin > >Please drop this from all stable queues. As the commit message and >missing stable-cc tag suggests, it's not needed. > >Sasha, please stop sending AUTOSEL patches for usb-serial. I think this >the fourth time I ask you now. Right, this series is a bit different because it didn't originate from the AUTOSEL work but rather was an audit of patches picked up by downstream kernels as fixes. I'll drop it, sorry for the noise. -- Thanks, Sasha