Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: mlEh2Im5M+qAtXzucGcnhMIUVvpxmpvdfM7aXXXmhN95gLd4hHM4hvuKCzQCVViAPcgYWEwJdJ
 OmoqBFsH+14w==
IronPort-SDR: RIaUgM3EHIJHI/0MsE4kpaigZmmc9+INXgdb1x33SaUi7GanGArNF4CMvQtVGFMQOYVIsduaJL
 K2SoJTmoXvUQ==
Date:   Fri, 25 Sep 2020 00:07:07 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-sgx@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Jethro Beekman <jethro@fortanix.com>,
        akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
        asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com,
        conradparker@google.com, cyhanish@google.com,
        dave.hansen@intel.com, haitao.huang@intel.com,
        josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com,
        kmoy@google.com, ludloff@google.com, luto@kernel.org,
        nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com,
        rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com
Subject: Re: [PATCH v38 18/24] x86/vdso: Add support for exception fixup in
 vDSO functions
Message-ID: <20200924210656.GF108958@linux.intel.com>
References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com>
 <20200915112842.897265-19-jarkko.sakkinen@linux.intel.com>
 <20200923220712.GU28545@zn.tnic>
 <20200924120851.GE56811@linux.intel.com>
 <20200924160057.GK5030@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200924160057.GK5030@zn.tnic>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Sep 24, 2020 at 06:00:57PM +0200, Borislav Petkov wrote:
> On Thu, Sep 24, 2020 at 03:09:01PM +0300, Jarkko Sakkinen wrote:
> > This is not technically SGX specific patch. Is SGX documentation the
> > correct place for this?
> 
> So what is it then? It is SGX implementation-specific. Why would you not
> put it in the documentation?!
> 
> > From checkpatch I only get:
> 
> Please concentrate and start reading more carefully:
> 
> ".git/rebase-apply/patch:122: new blank line at EOF."
> 
> Would that error come from checkpatch?

Nope. And I did fully read what you wrote. I just mentioned that more in
the tone that I should (and will) do also git am test from now on, at
least for mainline tree (when applicable) and x86 tip.

Right now the static tests that I do are checkpatch and sparse. Any
other suggestions are welcome.

I would also also coccicheck but have had some version issues with it in
Ubuntu, which I use as my host OS. Cannot recall what was the exact
issue, has been a while since I last tried it.

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko