Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 24 Sep 2020 17:30:10 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     John Hubbard <jhubbard@nvidia.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        Kirill Shutemov <kirill@shutemov.name>,
        Hugh Dickins <hughd@google.com>,
        Christoph Hellwig <hch@lst.de>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jann Horn <jannh@google.com>
Subject: Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned
Message-ID: <20200924213010.GL79898@xz-x1>
References: <20200922175415.GI19098@xz-x1>
 <20200922191116.GK8409@ziepe.ca>
 <20200923002735.GN19098@xz-x1>
 <20200923170759.GA9916@ziepe.ca>
 <20200924143517.GD79898@xz-x1>
 <20200924165152.GE9916@ziepe.ca>
 <20200924175531.GH79898@xz-x1>
 <20200924181501.GF9916@ziepe.ca>
 <20200924183418.GJ79898@xz-x1>
 <20200924183953.GG9916@ziepe.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200924183953.GG9916@ziepe.ca>
Precedence: bulk

On Thu, Sep 24, 2020 at 03:39:53PM -0300, Jason Gunthorpe wrote:
> On Thu, Sep 24, 2020 at 02:34:18PM -0400, Peter Xu wrote:
> 
> > > >        // RDONLY gup
> > > >        pin_user_pages(buf, !WRITE);
> > > >        // pte of buf duplicated on both sides
> > > >        fork();
> > > >        mprotect(buf, WRITE);
> > > >        *buf = 1;
> > > >        // buf page replaced as cow triggered
> > > > 
> > > > Currently when fork() we'll happily share a pinned read-only page with the
> > > > child by copying the pte directly.  
> > > 
> > > Why? This series prevents that, the page will be maybe_dma_pinned, so
> > > fork() will copy it.
> > 
> > With the extra mprotect(!WRITE), I think we'll see a !pte_write() entry.  Then
> > it'll not go into maybe_dma_pinned() at all since cow==false.
> 
> Hum that seems like a problem in this patch, we still need to do the
> DMA pinned logic even if the pte is already write protected.

Yes I agree.  I'll take care of that in the next version too.

-- 
Peter Xu