Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 25 Sep 2020 01:10:48 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     qianjun.kernel@gmail.com, peterz@infradead.org, will@kernel.org,
        luto@kernel.org, linux-kernel@vger.kernel.org,
        laoar.shao@gmail.com, qais.yousef@arm.com, urezki@gmail.com
Subject: Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing
 loop
Message-ID: <20200924231048.GD19346@lenoir>
References: <20200915115609.85106-1-qianjun.kernel@gmail.com>
 <20200915115609.85106-5-qianjun.kernel@gmail.com>
 <878scz89tl.fsf@nanos.tec.linutronix.de>
 <20200924230811.GC19346@lenoir>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200924230811.GC19346@lenoir>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Sep 25, 2020 at 01:08:11AM +0200, Frederic Weisbecker wrote:
> On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote:
> > Subject: softirq; Prevent starvation of higher softirq vectors
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Thu, 24 Sep 2020 10:40:24 +0200
> > 
> > From: Thomas Gleixner <tglx@linutronix.de>
> > 
> > The early termination of the softirq processing loop can lead to starvation
> > of the higher numbered soft interrupt vectors because each run starts at
> > the lowest bit. If the loop terminates then the already processed bits can
> > be raised again before the next loop starts. If these lower bits run into
> > the termination again, then a re-raise might starve the higher bits forever.
> > 
> > To prevent this, store the leftovers of the previous run in the upper 16
> > bit of the local softirq_pending storage and ensure that these are
> > processed before any newly raised bits are handled.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> >  kernel/softirq.c |   58 +++++++++++++++++++++++++++++++++++++++++++++++--------
> >  1 file changed, 50 insertions(+), 8 deletions(-)
> > 
> > --- a/kernel/softirq.c
> > +++ b/kernel/softirq.c
> > @@ -259,11 +259,23 @@ static inline bool __softirq_needs_break
> >  	return need_resched() || __softirq_timeout(tbreak);
> >  }
> >  
> > +/*
> > + * local_softirq_pending() is split into two 16 bit words. The low word
> > + * contains the bits set by raise_softirq(), the high word contains pending
> > + * bits which have not been processed in an early terminated run. This is
> > + * required to prevent starvation of the higher numbered softirqs.
> > + */
> > +#define SIRQ_PREV_SHIFT		16
> 
> Note that in the case of x86, irq_start.__softirq_pending is a u16.

irq_stat even