Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9Hc2pzNECPv5G4I4WAX65G5tO+9UlmZ4HaNrWtbQwd0RxOiSQNNrQ1Hwh+JkAHL5k87BMerV4l
 1x9tZQcQb1oQ==
IronPort-SDR: nDslaICw6OZoGWsFRlqPXAUKCLSwtpovhnuBBMu184OuC61vJMzD3zzeHyIMt+OhfFhj63rwRW
 ZBRKsIhYdScA==
Date:   Fri, 25 Sep 2020 02:11:08 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-sgx@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Jethro Beekman <jethro@fortanix.com>,
        akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
        asapek@google.com, cedric.xing@intel.com, chenalexchen@google.com,
        conradparker@google.com, cyhanish@google.com,
        dave.hansen@intel.com, haitao.huang@intel.com,
        josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com,
        kmoy@google.com, ludloff@google.com, luto@kernel.org,
        nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com,
        rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com
Subject: Re: [PATCH v38 20/24] x86/traps: Attempt to fixup exceptions in vDSO
 before signaling
Message-ID: <20200924231059.GG119995@linux.intel.com>
References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com>
 <20200915112842.897265-21-jarkko.sakkinen@linux.intel.com>
 <20200924163128.GM5030@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200924163128.GM5030@zn.tnic>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Sep 24, 2020 at 06:31:28PM +0200, Borislav Petkov wrote:
> On Tue, Sep 15, 2020 at 02:28:38PM +0300, Jarkko Sakkinen wrote:
> > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c
> > index 9e5ec861aba0..ebe290a68c36 100644
> > --- a/arch/x86/mm/fault.c
> > +++ b/arch/x86/mm/fault.c
> > @@ -30,6 +30,7 @@
> >  #include <asm/cpu_entry_area.h>		/* exception stack		*/
> >  #include <asm/pgtable_areas.h>		/* VMALLOC_START, ...		*/
> >  #include <asm/kvm_para.h>		/* kvm_handle_async_pf		*/
> > +#include <asm/vdso.h>			/* fixup_vdso_exception()	*/
> >  
> >  #define CREATE_TRACE_POINTS
> >  #include <asm/trace/exceptions.h>
> > @@ -775,6 +776,10 @@ __bad_area_nosemaphore(struct pt_regs *regs, unsigned long error_code,
> >  
> >  		sanitize_error_code(address, &error_code);
> >  
> > +		if (fixup_vdso_exception(regs, X86_TRAP_PF, error_code,
> > +		    address))
> 
> No need to break that line.

Thanks, fixed.

> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko