Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 25 Sep 2020 02:39:49 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Horatiu Vultur <horatiu.vultur@microchip.com>
Cc:     Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paul.burton@mips.com>,
        James Hogan <jhogan@kernel.org>, linux-mips@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        "Allan W. Nielsen" <allan.nielsen@microchip.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>, hongbo.wang@nxp.com
Subject: Re: [PATCH net-next v3 1/2] net: mscc: ocelot: Add support for tcam
Message-ID: <20200924233949.lof7iduyfgjdxajv@skbuf>
References: <1559287017-32397-1-git-send-email-horatiu.vultur@microchip.com>
 <1559287017-32397-2-git-send-email-horatiu.vultur@microchip.com>
 <CA+h21hprXnOYWExg7NxVZEX9Vjd=Y7o52ifKuAJqLwFuvDjaiw@mail.gmail.com>
 <20200423082948.t7sgq4ikrbm4cbnt@soft-dev3.microsemi.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200423082948.t7sgq4ikrbm4cbnt@soft-dev3.microsemi.net>
Precedence: bulk

Hi Horatiu,

On Thu, Apr 23, 2020 at 10:29:48AM +0200, Horatiu Vultur wrote:
> > > +static const struct vcap_props vcap_is2 = {
> > > +       .name = "IS2",
> > > +       .tg_width = 2,
> > > +       .sw_count = 4,
> > > +       .entry_count = VCAP_IS2_CNT,
> > > +       .entry_words = BITS_TO_32BIT(VCAP_IS2_ENTRY_WIDTH),
> > > +       .entry_width = VCAP_IS2_ENTRY_WIDTH,
> > > +       .action_count = (VCAP_IS2_CNT + VCAP_PORT_CNT + 2),
> > > +       .action_words = BITS_TO_32BIT(VCAP_IS2_ACTION_WIDTH),
> > > +       .action_width = (VCAP_IS2_ACTION_WIDTH),
> > > +       .action_type_width = 1,
> > > +       .action_table = {
> > > +               {
> > > +                       .width = (IS2_AO_ACL_ID + IS2_AL_ACL_ID),
> > > +                       .count = 2
> > > +               },
> > > +               {
> > > +                       .width = 6,
> > > +                       .count = 4
> > > +               },
> > > +       },
> > > +       .counter_words = BITS_TO_32BIT(4 * ENTRY_WIDTH),
> > > +       .counter_width = ENTRY_WIDTH,
> > > +};

Coming again to this patch, I'm having a very hard time understanding
how VCAP_IS2_ENTRY_WIDTH is derived and what it represents, especially
since the VCAP_CONST_ENTRY_WIDTH register reads something different.
Could you please explain?

Thanks,
-Vladimir