Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp795790pxk; Thu, 24 Sep 2020 20:14:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7rZXbuhP5NvpNju1OzqmpYfd/tjKGtuUXFjpELHaaZpkAbfTM6Z6yWerO+HrLdDhN9xok X-Received: by 2002:a17:906:edd6:: with SMTP id sb22mr637832ejb.499.1601003667222; Thu, 24 Sep 2020 20:14:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601003667; cv=none; d=google.com; s=arc-20160816; b=zZT/i6+ewVM8xGG+cxesRI4Uwgrv8gU25s7UFmxQmSxnc1KHFoRMfAflrDYL9F0H4b mA4xdVhgqDqL20djKL/tGwYu58+oe1z43PC6eoBecC6pdNT6gCXDjISKHYe9v+M2XJx1 JGAwJzGgvmv4NmSbRvx51Tl67Bgq8CEFiqmyARArSrlqnzpDmcOihNCrMvfyVaTgmQzE Gk3Sh67IUPMdcbjmfkiB26bw2pnDDYYgRSb7lldAVpXyzCOL7bR37hhKq0ny+AcT/KbY MT2Ko7ZIFc8pWIZSHEA4szYmvfEyGMA9e7XXqksN69Khv2jkqqJB9NhvzzibyOb5b4rH vzcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=Ha6tG50ZAdcygyNgY7BEaLEh3Ic0aMprLLFMB2vRMOQ=; b=QV07jMIVOJ4WG6ERQveXiL/sRrxkAp1BSQTnLxVPKzYnvtWqr2cx+I8AIxn/KKNOCn qdBKzuo7MGBmYLv1PQSeOkx9iWZAxrhTpNjccsjHQMQrdO02dR6QyT0ujE32FhCaLgMC R1sxJZcOlWOjpAnRXPxARqOzlXjak7tANc2EutYmwvV8t/1UfeZKEXbTpighwYBjBB0l +w/AqI4p/neNFc/EuLIQa5vfXhTgPA/phpuKiNlqDAxJpXw31sDalrAPFEZjfuAjIYOh PlgrSORx8qRJT2mCayKb++io8DFDpf2oNWGvjZMt40HKHTlxWMuwUZZ53W2G+e1NxClk 296w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jYwOpAwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id us11si932708ejb.268.2020.09.24.20.14.04; Thu, 24 Sep 2020 20:14:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jYwOpAwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726977AbgIYDKf (ORCPT + 99 others); Thu, 24 Sep 2020 23:10:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:54990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgIYDKf (ORCPT ); Thu, 24 Sep 2020 23:10:35 -0400 Received: from X1 (unknown [104.245.68.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D417206C1; Fri, 25 Sep 2020 03:10:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601003434; bh=Ds+x7kGYL6Aj7LMGPrjmzDsE6gk5ChKlSYdVj+ut8w0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jYwOpAwVfVctDlpMmjnjRUplgtiMt4mV/5scgwfkjbJ6Bo5ZjwM6v7bL0dquOqNJl cMP1JYdzy0PkLqhIbfblhX1qQY3EeW4keEDOoQtxsxTtwT6gF6md8ZIWvyY794zHBX tDCtAsNRAAu2pViXvPTs3EYpcv9VqpkEdfxURzr4= Date: Thu, 24 Sep 2020 20:10:33 -0700 From: Andrew Morton To: "Huang\, Ying" Cc: Rafael Aquini , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: swapfile: avoid split_swap_cluster() NULL pointer dereference Message-Id: <20200924201033.64e22c2915a8f2be3aacd97f@linux-foundation.org> In-Reply-To: <87v9g2blma.fsf@yhuang-dev.intel.com> References: <20200922184838.978540-1-aquini@redhat.com> <20200922124750.67a20d9764ec098b17705407@linux-foundation.org> <20200923134251.GN795820@optiplex-lnx> <20200924195914.d240877a10e22b457bd9b45d@linux-foundation.org> <87v9g2blma.fsf@yhuang-dev.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Sep 2020 11:06:53 +0800 "Huang\, Ying" wrote: > >> UGH! I missed adding it to my cc list. Shall I just forward it, now, or > >> do you prefer a fresh repost? > > > > I added the cc:stable to my copy. > > Please don't merge this patch. This patch doesn't fix the bug, but hide > the real bug. I will work with Rafael on root causing and fixing. Yup, I saw the discussion and have put the patch on hold pending the outcome.