Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp857424pxk; Thu, 24 Sep 2020 22:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwM8vKypQgZ/4ddc1bdQZ14jDhXXslNbVAQpASoNBq1JR0bfinxc9I7rkNwt0zPHY1muGaQ X-Received: by 2002:a17:906:915:: with SMTP id i21mr1048038ejd.113.1601012684148; Thu, 24 Sep 2020 22:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601012684; cv=none; d=google.com; s=arc-20160816; b=AlHhTpxcIPKH8DFPw7oo68Hor8EXqCEJF/bBK5zahrk0yRl0eeOg/JJrOFDL21Sz2E IvSK22Zb9nNTDgO8C+pJC+464qYxEH4aiZn/sTMMqYYbhmsbK5EtouLZ70W/co/K2QKG dLz1KY3cMCIsrFZMvV/UKhBi5m74qbCJJLAg1QUuiGvMfW3EUVdP2a2VAvT1LqkYZy53 lqQStUvxxItnW4uxfHopvmCGTeKsOXIe3otVabbLo135+vfkdCCXmrsZqid5wdCiSZGt t9Qd5XY2eJn8vvdVhsvOZoUfEnXSfYU9dbXwBnu2N4JhnvhJRQiXjfKAgac/5tJF2JLe HReg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=a+rc8iW7+Wf9/R6fqJhx0Q6lGFX97vxVjL4LV3SqwSc=; b=EKEZst8MeyTrl7p4vET4YfsP1J3jxc1UpCr54IH2eeYREkk+GelxZ2F6N4bCDZ47X6 Uxu7v7j4BzspGLltib9kDK9HyZHUgxAhC90nmWPcRyS65zZHtvphnEri97QFAzsikBBK dpvYpHeXN3fBOcZGf8pqc+HkVorFAIwtP66BpHB6CHKXRqvi+ykU65ExdMY9rgrRueLZ SZa9VdcFIT1dv8GolsLDkAlo+m6uJ8KYG1X9LwTrcRAsYzojziK4cTgkMkupzcV5TCA1 IBLoPk0aBJBN1CQkf7gVVVOFjhNJV0ltwpKOvzSbI1V/s/7jciLOWkZNcQKvtY14fI1+ cc3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si1160532ejc.542.2020.09.24.22.44.19; Thu, 24 Sep 2020 22:44:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbgIYFnT (ORCPT + 99 others); Fri, 25 Sep 2020 01:43:19 -0400 Received: from mga12.intel.com ([192.55.52.136]:63311 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726925AbgIYFnS (ORCPT ); Fri, 25 Sep 2020 01:43:18 -0400 IronPort-SDR: 596ihZ6WvUD0getK0hMzORkCv99ZI34ONHhOfgcUeRpcxtiWGLwEw9axZLY0znpzHYvJ3c8O4L kCx2tv1aQxvw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="140863320" X-IronPort-AV: E=Sophos;i="5.77,300,1596524400"; d="scan'208";a="140863320" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 22:43:18 -0700 IronPort-SDR: fd4ITIhTxcQZZfnwoepJLdugVs8r1WtFhOoLToH1S5iY96G0wBOocQXZXY11Ztf63VOZq7kx8f zpi90Z27C95w== X-IronPort-AV: E=Sophos;i="5.77,300,1596524400"; d="scan'208";a="487319116" Received: from erybin-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.47.248]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 22:43:15 -0700 Date: Fri, 25 Sep 2020 08:43:13 +0300 From: Jarkko Sakkinen To: Ross Philipson Cc: linux-kernel@vger.kernel.org, x86@kernel.org, iommu@lists.linux-foundation.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, dpsmith@apertussolutions.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, luto@amacapital.net, trenchboot-devel@googlegroups.com Subject: Re: [PATCH 05/13] x86: Add early TPM1.2/TPM2.0 interface support for Secure Launch Message-ID: <20200925054313.GB165011@linux.intel.com> References: <1600959521-24158-1-git-send-email-ross.philipson@oracle.com> <1600959521-24158-6-git-send-email-ross.philipson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1600959521-24158-6-git-send-email-ross.philipson@oracle.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 10:58:33AM -0400, Ross Philipson wrote: > From: "Daniel P. Smith" > > This commit introduces an abstraction for TPM1.2 and TPM2.0 devices > above the TPM hardware interface. > > Signed-off-by: Daniel P. Smith > Signed-off-by: Ross Philipson This is way, way too PoC. I wonder why there is no RFC tag. Please also read section 2 of https://www.kernel.org/doc/html/v5.8/process/submitting-patches.html You should leverage existing TPM code in a way or another. Refine it so that it scales for your purpose and then compile it into your thing (just include the necesary C-files with relative paths). How it is now is never going to fly. /Jarkko