Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp876323pxk; Thu, 24 Sep 2020 23:28:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuw/BQyk1m8eOTNpiaHcK1E96tn8xKhyMHJbMEPxcfS32+msQnuT2X6sw9dR/0xwc4quOt X-Received: by 2002:a17:906:f9d3:: with SMTP id lj19mr1199112ejb.346.1601015285898; Thu, 24 Sep 2020 23:28:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601015285; cv=none; d=google.com; s=arc-20160816; b=kqvxQoW7k+KqOuTpqRak9h7LrIY/D6aqAKrEJGOgNONicwIoNxEXu561+GhaBZG7G5 bjWX2oE4QknuYlTMYpi5PbyMv1A5fxpziV5fdhI23rvTd4LcAO+h16bEMoXxTDz23n8/ JjMjAgqGYDidBtEgVlv2O5lK0aauIpRhSkYbyrIcau9vtF7ibEBwVGyxc7LrC6HX8KUX jux3/u3Jw1LgTg8zfGiiNvHpY09kXj5g76/akVh1Qb6TKtL/fuXwXwQLNcgv7FI5pO+/ KNnAbiQ4nn685+u8g6wrf2ruyotVdP3nxbNWWzBxwjSLOEfphfGEV8/phHVpnNpa5MoD GJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RE0Hnz7MdIYRFOkUomxd6mAr8+TrNkSbeCkMI7F92V0=; b=mc+s2H4CVScv+OK4lGycr7zwgEshQQKy6UM/XKX6eGHfAzhqfn3GT/cfrzzEBuZxig 1mClBo3K9l00/Z5DC2RKr4NKnQKO99whc5qPBnFsOvkKE+Z/nAixxEcpVbpZ+9d/rQm1 Kw8l0LQrS8I6UFfDCx9t4QIXIBbAkK/W17xDNtuuNc6D/YnGb6eBVmDAMEF7ZC7jwZBL Cbno+E8uY+3Nu5RWNNSSICe0ySwt9ZAmiKDE9Hq7drzjVKsR+IYh6Y+HJZodWbW4RM0R O6dTdeDTJ5s2TkApFYZzlqfGEXtoDBBbq9TjN3BMDBIMDb+XBrX9LbiDWe7DePW6msMK khQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v15si1258962edw.67.2020.09.24.23.27.42; Thu, 24 Sep 2020 23:28:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727408AbgIYGYd (ORCPT + 99 others); Fri, 25 Sep 2020 02:24:33 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:58336 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727176AbgIYGYd (ORCPT ); Fri, 25 Sep 2020 02:24:33 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1FE87947832B141A87E8; Fri, 25 Sep 2020 14:24:31 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Fri, 25 Sep 2020 14:24:24 +0800 From: Jing Xiangfeng To: , , , , , CC: , , Subject: [PATCH] scsi: bfa: fix error return in bfad_pci_init() Date: Fri, 25 Sep 2020 14:24:23 +0800 Message-ID: <20200925062423.161504-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code -ENODEV from the error handling case instead of 0. Fixes: 11ea3824140c ("scsi: bfa: fix calls to dma_set_mask_and_coherent()") Signed-off-by: Jing Xiangfeng --- drivers/scsi/bfa/bfad.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/bfa/bfad.c b/drivers/scsi/bfa/bfad.c index bc5d84f87d8f..440ef32be048 100644 --- a/drivers/scsi/bfa/bfad.c +++ b/drivers/scsi/bfa/bfad.c @@ -749,6 +749,7 @@ bfad_pci_init(struct pci_dev *pdev, struct bfad_s *bfad) if (bfad->pci_bar0_kva == NULL) { printk(KERN_ERR "Fail to map bar0\n"); + rc = -ENODEV; goto out_release_region; } -- 2.17.1