Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp894340pxk; Fri, 25 Sep 2020 00:07:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxA3QN77iZj56kA8xgSU7Jo18vxHEkHGDDxCiPMbLG6nGtto6v+7FDhMCKmVjA38pZWvayP X-Received: by 2002:a17:906:1e51:: with SMTP id i17mr1411582ejj.103.1601017654667; Fri, 25 Sep 2020 00:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601017654; cv=none; d=google.com; s=arc-20160816; b=WlHr5EBeJQ3fnvKVo/AuP30/u70HrjhoOTouLF9823FqHDuMh5ByR5YOmYjyrb9juo GpK456Yy53pQ3cgCHNx0qz61Q8dd6ZlsJSI/DTZqkUGNWFe/PyM9Qz4QiVvIGRkceqdQ dX900fCtkf7EMTuM6bfpxSxmlE+9cUecN9PZeEORvm3iyl6bOU3WZgWrKXIoH0sJ/vJK s5ygICK9O/3l0QkT1ghpnNqLAVL/cPwwfCj5LsSrsfW+VBMA4Cxt35G9t2zIgo6XsDAc HbV1UdOGD9xOqhpQZbYqskGgBVseKXFsEeFQc1B3yNc3dqjBemZEC92Ea2+9wr8BEsQN vfjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=QQ2o3TxaffDDfH8Bg9LEnQonYO+120y9jWDCgEhNgyc=; b=0/IxT6SK5J7dhaVCQc6FDIiu89Fa9voKldY7lUmWeaZxWV89My9XlNL0G08TCx3dAd mrqbR+IJrf6snKMjaIHRftFZmaRdnsDyQ28OXaF3JR7I7U/VU8IKk/wppyRunzfSWNwe qjgPrJjY/O2IwGnLbsQDkBS/fkEl6zjUG8tRc+fjiPLo8br4jHovDRXq1pHqovql5tEn jItcYFDSFmgmymJAafsb7EAm+hBPuxMmaZ+NeqsmTCJEUc0ZcTePTyJe2KeIB+l5UUZh VbudULK2atyJGjmo9YSv7GNimQzZX4p3wwB8HNZTzELCKkq5A2MDF1r3RpffcGE1MgnL 58BQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cn3si1453693edb.282.2020.09.25.00.07.11; Fri, 25 Sep 2020 00:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727249AbgIYHEA convert rfc822-to-8bit (ORCPT + 99 others); Fri, 25 Sep 2020 03:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbgIYHEA (ORCPT ); Fri, 25 Sep 2020 03:04:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F451C0613CE for ; Fri, 25 Sep 2020 00:04:00 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLhlp-0007xq-2N; Fri, 25 Sep 2020 09:03:53 +0200 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kLhln-0005hB-6X; Fri, 25 Sep 2020 09:03:51 +0200 Date: Fri, 25 Sep 2020 09:03:51 +0200 From: Oleksij Rempel To: Christian Eggers Cc: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-i2c@vger.kernel.org Subject: Re: [PATCH 0/3] i2c: imx: Fix handling of arbitration loss Message-ID: <20200925070351.vrxdlmx6ijfzwbg7@pengutronix.de> References: <20200917122029.11121-1-ceggers@arri.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200917122029.11121-1-ceggers@arri.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:50:47 up 314 days, 22:09, 333 users, load average: 0.04, 0.03, 0.00 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 02:20:26PM +0200, Christian Eggers wrote: > On my (noisy) system, I2C arbitration losses happen quite often. In it's > current implementation, the IAL flag is partly handled, but has a > number of shortcomings: > > 1. The driver runs unnecessarily in a timeout when waiting for an > interrupt. > > 2. The driver performs 500 ms busy-waiting without any value. > > 3. Arbitration loss errors may be reported one transfer later than they > occured. > > Best regards > Christian > Acked-by: Oleksij Rempel Thank you! -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |