Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp903077pxk; Fri, 25 Sep 2020 00:25:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKC4Ddm3Ej8J8X3BUiA3ZOkDDsrgUsBchvFhNMmA+qz7fjajxjeVZlWLUDC/BypQQe4eI9 X-Received: by 2002:a17:907:408d:: with SMTP id nt21mr1348862ejb.355.1601018733275; Fri, 25 Sep 2020 00:25:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601018733; cv=none; d=google.com; s=arc-20160816; b=fz8+i00bOpV9EyGZ61PwHd3zu7RxWZbJtw8RkBE7hHeitAEwTrpiTpEJDT4vxJc9Jm 5ifEkfK9T+iN1rc5FyaPcQQeA6NynZWJ3O/DfFSToDU+DsituK977r6qzkjoLAtp4nO9 rQ9PScHIz1bR4mrum4qBrm/Usfns92NdmzQ7fY/XfEfK7O1YgnxH4x3x0Swqnig0MYrd ZhDCKijCHoX1HsoG1ZzV6+EJt4Qfk4kfk53VmUTjag6epNU64sZORjuOIWwupbNe2iRc MF7ZqFJvWn4Li4c3yk+5QRKbx1byxH37vhf1IKiJ93PE0PdJHUaWAFz/hP94IKVPr4VJ Yo5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Wjlu/ndJbxVTFlpp3T1F/epZ459T0Uni2kaVnS/ZU6M=; b=z1Bhr/7DZ1D7B+KqhAL5shbOQpDmyU/TLWLJqwTrO/0gvl5sO3xmI4rMI4qyvMI2VK XggecAOycunAv15aNmBxfLpgl7M/pjePsvfkIpkWh+J+RmA+eFdGzdHPNuCTEqWJOXiL 07lmpjvYSpHEfGte5lb3sYyTPikuZo1kv+45No2oFBtO9Pqm7qXQmS4lhbXv3Vaknmzy 9qrQC5UFkNlRAlfKxPrp5LYegEuiC1a5kEJ9rkNxUe2AZyfU1ShZcdim2WuKjPKW3U/l 6z1QOkRRETVDXjbmcP9njgiY+uRN7kXx29MHVcnMLWgEIGIHoGZCad8+DVbTxphL6tag zWzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=mdRVSHbt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l14si1179458ejz.622.2020.09.25.00.25.10; Fri, 25 Sep 2020 00:25:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=mdRVSHbt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbgIYHXD (ORCPT + 99 others); Fri, 25 Sep 2020 03:23:03 -0400 Received: from mail.skyhub.de ([5.9.137.197]:54216 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727068AbgIYHXD (ORCPT ); Fri, 25 Sep 2020 03:23:03 -0400 Received: from zn.tnic (p200300ec2f0b3a00d3756fc4b2470eaa.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:3a00:d375:6fc4:b247:eaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A5DB91EC0473; Fri, 25 Sep 2020 09:23:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1601018581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Wjlu/ndJbxVTFlpp3T1F/epZ459T0Uni2kaVnS/ZU6M=; b=mdRVSHbtVf7FFy4Uxm049cBs2q8MUyePRVieH4Q2zgvP/UJJ2lw3FGflMQhwn7ofkbHP87 fI72aMJ4JbJnrCMxtCQWMiPS1XD9Ou/DxYW4AIw0+ilKgEMheHz3cqJg7TvNyGG8QHg+i3 gDZBrDnPEGIdqs77M5qk8wFH15Iqjl4= Date: Fri, 25 Sep 2020 09:22:31 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org, Smita.KoralahalliChannabasappa@amd.com Subject: Re: [PATCH v2 8/8] x86/MCE/AMD Support new memory interleaving modes during address translation Message-ID: <20200925072231.GC16872@zn.tnic> References: <20200903200144.310991-1-Yazen.Ghannam@amd.com> <20200903200144.310991-9-Yazen.Ghannam@amd.com> <20200923082039.GB28545@zn.tnic> <20200923162510.GB1684790@yaz-nikka.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200923162510.GB1684790@yaz-nikka.amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 23, 2020 at 11:25:10AM -0500, Yazen Ghannam wrote: > I don't remember the original reason, and I was recently asked about > this code living in a module. I did some looking after this ask, and I > found that we should be using this translation to get a proper value for > the memory error notifiers to use. So I think we still need to use this > function some way with the core code even if the EDAC interface isn't > used. You'd need to be more specific here, you want to bypass amd64_edac to decode errors? Judging by the current RAS activity coming from you guys, I'm thinking firmware. But then wouldn't the firmware do the decoding for us and then this function is not even needed? > What do you think? I think you should explain what the use case is first. :) Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette