Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200925033017.1790973-1-art@khadas.com> <20200925033017.1790973-2-art@khadas.com>
In-Reply-To: <20200925033017.1790973-2-art@khadas.com>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Fri, 25 Sep 2020 09:51:14 +0200
Message-ID: <CAFBinCDcwHUJzK4HsvKxs1n4_jH9K47bNZcZobocLxKVj7+iNw@mail.gmail.com>
Subject: Re: [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2
To:     Artem Lapkin <email2tema@gmail.com>
Cc:     Neil Armstrong <narmstrong@baylibre.com>, khilman@baylibre.com,
        robh+dt@kernel.org, jbrunet@baylibre.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        art@khadas.com, nick@khadas.com, gouwa@khadas.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Artem,

On Fri, Sep 25, 2020 at 5:30 AM Artem Lapkin <email2tema@gmail.com> wrote:
>
> 1) The VIM2 Boards use w25q128 spi chip only not w25q32 or w25q16
>    it's not really seriously becouse have 'jedec,spi-nor' which
>    have auto chips identifications
according to the "VIM2 - Transitioning From v1.2 to v1.4" document [0]
(page 7) both board revisions are using different SPI flash sizes
for which board revision are your changes?

> 2) max-frequency is 104Mhz
(note to self: according to the w25q16 datasheet it supports a maximum
clock frequency of 104MHz, so this is fine)


Best regards,
Martin