Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp918995pxk; Fri, 25 Sep 2020 01:01:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqJyFMu6l/6JZYKvqrhveZ6bK5R8gCp+0by/ZxsMBtzbLE3JxbtNyZoAbO3rb1Izap3tFk X-Received: by 2002:a05:6402:184d:: with SMTP id v13mr11098edy.240.1601020887882; Fri, 25 Sep 2020 01:01:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601020887; cv=none; d=google.com; s=arc-20160816; b=XvqccPGaSOlx+iCyQuDkuhAauw6LaJnoA3ZCqIawx6KA6+gL1qsHwG7W219F57nZ4N n/WaQkquEXgENllECtuUXlmM4tQS28b1w0p1mi7kxgnv90RuB3PtxqvOkE+VsWholjEU nF3omhf2Rz4R1uEoETNmWdvu6VunYBxfkE/ZyU4D8SXxYP6Vw00eca56Eo216L+7O9+t LJeOOP7wmH6N9fEV+JqyZCKA2hQPuxKIjBZ/XniiYQP8pWj9M4TFX1vP2W+UFHbu8Q/e fWNsyZsWzBQvdxMcUAsONTN2t++E2o6p7XdLLWhp70tx7M3QPGVDEYartOds2Sl+FDjY 8dNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=IACuVpEoNDXDDASnAYj5laHeCf2VqIWkSoG9vQ+sQdQ=; b=lrYcojOx56HZdXg5NWDLtcwsbMQJ0lLwdrb1bcMbX/BEXSOJdWQXLQP7LWOtPc3skm Zs6hMl2fD5SYsf2cZ0mQnxiD7MsJdOCjWF2FyC8y0CReZjlp0ky4mUx/BDQMvq5uKFyn KBxH0q5avxtiJjfuE9f8YH0hiFyPpx190SuI+4oXAXn3AwJDagqQrFaMD3n6MGlgZRom 47RZ4pfXSUmzsvSCHrkE8DZuu4byQywNaKBVu4HT5Ly5N2n4g74/DAwTAeXI20byLZzI vTGw4e2BpqkRZ54f19jwVVC+ImbN/3v6IpAOF+Vv0owEiRWGh9kSFJfRR4Z5hPlfhRI7 /miQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gdkkb9dB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si1327891ejq.317.2020.09.25.01.01.03; Fri, 25 Sep 2020 01:01:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gdkkb9dB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727723AbgIYH7v (ORCPT + 99 others); Fri, 25 Sep 2020 03:59:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbgIYH7v (ORCPT ); Fri, 25 Sep 2020 03:59:51 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68D29C0613CE; Fri, 25 Sep 2020 00:59:51 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id b142so1381829ybg.9; Fri, 25 Sep 2020 00:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=IACuVpEoNDXDDASnAYj5laHeCf2VqIWkSoG9vQ+sQdQ=; b=gdkkb9dB0GGYdugDaFQeCRQAbgbgHYU5sbOsIS80WyjaowJXeUEdLhaCQtNgprboVW XalpbQAIFAYnRt829j5H3hIOUWoS9ry5FbtKriPvCkbpQEWEANq+prbHMLPZ0Tfm1CP5 zyOgVeMgxoSCT2uB5RXXZ6RPQjxC/+qa/qDlt1e6EhCxHxU83N/bOw1/0gzrnXEOy7vI t5vInPjFAGkziKns4kiPQ1Rw9XE+E9RV15eZXLlKPa03Z2E5L3Yvf+AJ2TymEkgsZES5 J26VnMgwf6j1idkrvw7kbF10Hbhm3M5trPIDl5qeDP/J4gMKF44Wn6sMP6LvHxHwMtNU MaQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=IACuVpEoNDXDDASnAYj5laHeCf2VqIWkSoG9vQ+sQdQ=; b=bbp5aYwdQ+ZPmpx3ErZEE64JTdFnKYfmADAsOHApEj9V1KYA7Bp0E8YRqKkQ7w/uIe GdMAGTrB+gJ4PCIx+03+Vh7E/Pd3ADnyuCz6GUvyZtL5p6CiSfdc4Jn3ysRTAtOimUHl yb0VnYyk0P3Qq3gY2zRgfKYF3tqb6ZVJfdGEyE6YkiBzDjfLJLVTmnBXW4c0NHcMNcZE eGpGiDpRlZnrOO3GWBDgpOnHkF/x7lIOaFpWLkh2A1MgBLa5QudgfVb/pBJeKTdDBLei 0oPeoOonv4W8viTnNqWccdQZplqOLLHGs5/2tCgWfW6pWkU3Noe/TYzcmfh0IyH3pje0 zETA== X-Gm-Message-State: AOAM532hq+X6MajuEgy+e34jd/z/Qg4vqwCAZrEGzSXMRcViGbQoQYaT Fxjv5mDQuaZc3f/LPAlL+t01wW2mri2OQ8TDVvsVMISD+MxBQA== X-Received: by 2002:a25:418e:: with SMTP id o136mr3692372yba.82.1601020790620; Fri, 25 Sep 2020 00:59:50 -0700 (PDT) MIME-Version: 1.0 References: <20200710111054.29562-1-benchuanggli@gmail.com> <9fa17d60-a540-d0d8-7b2c-0016c3b5c532@intel.com> <20200917051253.GA3094018@laputa> <20200918011502.GA27646@laputa> <20200924094620.GA38298@laputa> In-Reply-To: <20200924094620.GA38298@laputa> From: Ben Chuang Date: Fri, 25 Sep 2020 15:59:39 +0800 Message-ID: Subject: Re: [RFC PATCH V3 12/21] mmc: sdhci: UHS-II support, add hooks for additional operations To: AKASHI Takahiro , Ben Chuang , Adrian Hunter , Ulf Hansson , linux-mmc , Linux Kernel Mailing List , Ben Chuang , greg.tu@genesyslogic.com.tw, Renius.Chen@genesyslogic.com.tw Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Takahiro, On Thu, Sep 24, 2020 at 5:46 PM AKASHI Takahiro wrote: > > Ben, > > On Fri, Sep 18, 2020 at 06:27:01PM +0800, Ben Chuang wrote: > > On Fri, Sep 18, 2020 at 9:15 AM AKASHI Takahiro > > wrote: > > > > > > Ben, > > > > > > On Thu, Sep 17, 2020 at 06:12:27PM +0800, Ben Chuang wrote: > > > > Hi Takahiro, > > > > > > > > On Thu, Sep 17, 2020 at 1:12 PM AKASHI Takahiro > > > > wrote: > > > > > > > > > > Adrian, Ben, > > > > > > > > > > Regarding _reset() function, > > > > > > > > > > On Fri, Aug 21, 2020 at 05:08:32PM +0300, Adrian Hunter wrote: > > > > > > On 10/07/20 2:10 pm, Ben Chuang wrote: > > > > > > > From: Ben Chuang > > > > > > > > > > > > > > In this commit, UHS-II related operations will be called via a function > > > > > > > pointer array, sdhci_uhs2_ops, in order to make UHS-II support as > > > > > > > a kernel module. > > > > > > > This array will be initialized only if CONFIG_MMC_SDHCI_UHS2 is enabled > > > > > > > and when the UHS-II module is loaded. Otherwise, all the functions > > > > > > > stay void. > > > > > > > > > > > > > > Signed-off-by: Ben Chuang > > > > > > > Signed-off-by: AKASHI Takahiro > > > > > > > --- > > > > > > > drivers/mmc/host/sdhci.c | 152 ++++++++++++++++++++++++++++++++++----- > > > > > > > 1 file changed, 136 insertions(+), 16 deletions(-) > > > > > > > > > > > > > > > > > (snip) > > > > > > > > > > > > if (host->ops->platform_send_init_74_clocks) > > > > > > > host->ops->platform_send_init_74_clocks(host, ios->power_mode); > > > > > > > > > > > > > > @@ -2331,7 +2411,7 @@ void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > > > > > > } > > > > > > > > > > > > > > if (host->version >= SDHCI_SPEC_300) { > > > > > > > - u16 clk, ctrl_2; > > > > > > > + u16 clk; > > > > > > > > > > > > > > if (!host->preset_enabled) { > > > > > > > sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL); > > > > > > > @@ -3173,11 +3253,19 @@ static bool sdhci_request_done(struct sdhci_host *host) > > > > > > > /* This is to force an update */ > > > > > > > host->ops->set_clock(host, host->clock); > > > > > > > > > > > > > > - /* Spec says we should do both at the same time, but Ricoh > > > > > > > - controllers do not like that. */ > > > > > > > - sdhci_do_reset(host, SDHCI_RESET_CMD); > > > > > > > - sdhci_do_reset(host, SDHCI_RESET_DATA); > > > > > > > - > > > > > > > + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > > > > > > > + host->mmc->flags & MMC_UHS2_INITIALIZED) { > > > > > > > + if (sdhci_uhs2_ops.reset) > > > > > > > + sdhci_uhs2_ops.reset(host, > > > > > > > + SDHCI_UHS2_SW_RESET_SD); > > > > > > > + } else { > > > > > > > + /* > > > > > > > + * Spec says we should do both at the same time, but > > > > > > > + * Ricoh controllers do not like that. > > > > > > > + */ > > > > > > > + sdhci_do_reset(host, SDHCI_RESET_CMD); > > > > > > > + sdhci_do_reset(host, SDHCI_RESET_DATA); > > > > > > > + } > > > > > > > > > > > > Please look at using the existing ->reset() sdhci host op instead. > > > > > > > > > > Well, the second argument to those reset functions is a bit-wise value > > > > > to different "reset" registers, SDHCI_SOFTWARE_RESET and SDHCI_UHS2_SW_RESET, > > > > > respectively. > > > > > > > > > > This fact raises a couple of questions to me: > > > > > > > > > > 1) Does it make sense to merge two functionality into one, i.e. > > > > > sdhci_do_reset(), which is set to call ->reset hook? > > > > > > > > > > -> Adrian > > > > > > > > > > 2) UHS2_SW_RESET_SD is done only at this place while there are many callsites > > > > > of reset(RESET_CMD|RESET_DATA) in sdhci.c. > > > > > Why does the current code work? > > > > > > > > > > I found, in sdhci-pci-gli.c, > > > > > sdhci_gl9755_reset() > > > > > /* reset sd-tran on UHS2 mode if need to reset cmd/data */ > > > > > if ((mask & SDHCI_RESET_CMD) | (mask & SDHCI_RESET_DATA)) > > > > > gl9755_uhs2_reset_sd_tran(host); > > > > > > (A) > > > > > > > > > > > > > Is this the trick to avoid the issue? > > > > > (It looks redundant in terms of the hack above in sdhci_request_done() > > > > > and even quite dirty to me. Moreover, no corresponding code for gl9750 > > > > > and gl9763.) > > > > > > > > GL9755 currently does SD reset and UHS-II reset together. > > > > > > Do you mean that, in UHS-II operations, you need only the reset on > > > SDHCI_UHS2_SW_RESET register? > > > > No, GL9755 does SD reset and UHS-II reset together. > > Is this also true for all sdhci controller drivers in general? > As I said, I didn't find any precise description about this > in SD specification. No, sdhci_gl9755_reset() is only for GL9755. > > -Takahiro Akashi > > > > But the hunk above (A) does the UHS-II reset along with UHS-I reset. > > > > > > > There is no UHS-II interface on gl9750 and gl9763e. > > > > > > > > > > > > > > -> Ben > > > > > > > > > > 3) (More or less SD specification issue) > > > > > In UHS-II mode, do we have to call reset(SHCI_RESET_ALL) along with > > > > > reset(UHS2_SW_RESET_FULL)? > > > > > Under the current implementation, both will be called at the end. > > > > > > > > > > > > > As I know, the UHS2_SW_RESET_FULL is only for UHS-II. > > > > Can you list the lines that reset(SHCI_RESET_ALL) and > > > > reset(UHS2_SW_RESET_FULL) are both called? > > > > > > I was not clear here. (The above is also another example.) > > > > > > Look at sdhci_remove_host() and shdci_uhs2_remote_host(). > > > If the argument 'dead' is 0, we will do both of the resets for UHS-II. > > > > Do UHS2_SW_RESET_FULL in sdhci_uhs2_remove_host() and then do > > SDHCI_RESET_ALL in sdhci_remove_host() is ok. > > > > > > > > > > -Takahiro Akashi > > > > > > > > -> Adrian, Ben > > > > > > > > > > 4) (Not directly linked to UHS-II support) > > > > > In some places, we see the sequence: > > > > > sdhci_do_reset(host, SDHCI_RESET_CMD); > > > > > sdhci_do_reset(host, SDHCI_RESET_DATA); > > > > > while in other places, > > > > > sdhci_do_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA); > > > > > > > > > > If the statement below is true, > > > > > > > - /* Spec says we should do both at the same time, but Ricoh > > > > > > > - controllers do not like that. */ > > > > > the latter should be wrong. > > > > > > > > > > -> Adrian > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > > > > > > > > > > > > host->pending_reset = false; > > > > > > > } > > > > > > > > > > > > > > @@ -3532,6 +3620,13 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id) > > > > > > > SDHCI_INT_BUS_POWER); > > > > > > > sdhci_writel(host, mask, SDHCI_INT_STATUS); > > > > > > > > > > > > > > + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > > > > > > > + intmask & SDHCI_INT_ERROR && > > > > > > > + host->mmc->flags & MMC_UHS2_SUPPORT) { > > > > > > > + if (sdhci_uhs2_ops.irq) > > > > > > > + sdhci_uhs2_ops.irq(host); > > > > > > > + } > > > > > > > + > > > > > > > > > > > > Please look at using the existing ->irq() sdhci host op instead > > > > > > > > > > > > > if (intmask & (SDHCI_INT_CARD_INSERT | SDHCI_INT_CARD_REMOVE)) { > > > > > > > u32 present = sdhci_readl(host, SDHCI_PRESENT_STATE) & > > > > > > > SDHCI_CARD_PRESENT; > > > > > > > @@ -4717,6 +4812,14 @@ int sdhci_setup_host(struct sdhci_host *host) > > > > > > > /* This may alter mmc->*_blk_* parameters */ > > > > > > > sdhci_allocate_bounce_buffer(host); > > > > > > > > > > > > > > + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > > > > > > > + host->version >= SDHCI_SPEC_400 && > > > > > > > + sdhci_uhs2_ops.add_host) { > > > > > > > + ret = sdhci_uhs2_ops.add_host(host, host->caps1); > > > > > > > + if (ret) > > > > > > > + goto unreg; > > > > > > > + } > > > > > > > + > > > > > > > > > > > > I think you should look at creating uhs2_add_host() instead > > > > > > > > > > > > > return 0; > > > > > > > > > > > > > > unreg: > > > > > > > @@ -4738,6 +4841,8 @@ void sdhci_cleanup_host(struct sdhci_host *host) > > > > > > > { > > > > > > > struct mmc_host *mmc = host->mmc; > > > > > > > > > > > > > > + /* FIXME: Do we have to do some cleanup for UHS2 here? */ > > > > > > > + > > > > > > > if (!IS_ERR(mmc->supply.vqmmc)) > > > > > > > regulator_disable(mmc->supply.vqmmc); > > > > > > > > > > > > > > @@ -4766,6 +4871,14 @@ int __sdhci_add_host(struct sdhci_host *host) > > > > > > > mmc->cqe_ops = NULL; > > > > > > > } > > > > > > > > > > > > > > + if ((mmc->caps & MMC_CAP_UHS2) && !host->v4_mode) { > > > > > > > + /* host doesn't want to enable UHS2 support */ > > > > > > > + mmc->caps &= ~MMC_CAP_UHS2; > > > > > > > + mmc->flags &= ~MMC_UHS2_SUPPORT; > > > > > > > + > > > > > > > + /* FIXME: Do we have to do some cleanup here? */ > > > > > > > + } > > > > > > > + > > > > > > > host->complete_wq = alloc_workqueue("sdhci", flags, 0); > > > > > > > if (!host->complete_wq) > > > > > > > return -ENOMEM; > > > > > > > @@ -4812,6 +4925,9 @@ int __sdhci_add_host(struct sdhci_host *host) > > > > > > > unled: > > > > > > > sdhci_led_unregister(host); > > > > > > > unirq: > > > > > > > + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > > > > > > > + sdhci_uhs2_ops.remove_host) > > > > > > > + sdhci_uhs2_ops.remove_host(host, 0); > > > > > > > sdhci_do_reset(host, SDHCI_RESET_ALL); > > > > > > > sdhci_writel(host, 0, SDHCI_INT_ENABLE); > > > > > > > sdhci_writel(host, 0, SDHCI_SIGNAL_ENABLE); > > > > > > > @@ -4869,6 +4985,10 @@ void sdhci_remove_host(struct sdhci_host *host, int dead) > > > > > > > > > > > > > > sdhci_led_unregister(host); > > > > > > > > > > > > > > + if (IS_ENABLED(CONFIG_MMC_SDHCI_UHS2) && > > > > > > > + sdhci_uhs2_ops.remove_host) > > > > > > > + sdhci_uhs2_ops.remove_host(host, dead); > > > > > > > + > > > > > > > > > > > > I think you should look at creating uhs2_remove_host() instead > > > > > > > > > > > > > if (!dead) > > > > > > > sdhci_do_reset(host, SDHCI_RESET_ALL); > > > > > > > > > > > > > > > > > > > >