Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp919349pxk;
        Fri, 25 Sep 2020 01:01:59 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzlrXwr+9CPLgQd6rSVghcNOagcQp9Xd2yz0BlcFwaOTmbULN2H9pCeyd36/FKf1fqYmWZS
X-Received: by 2002:a05:6402:21c5:: with SMTP id bi5mr533edb.380.1601020919578;
        Fri, 25 Sep 2020 01:01:59 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601020919; cv=none;
        d=google.com; s=arc-20160816;
        b=jyK+cBqVJ96SBvo4AR6wgYMWqDRy84IHnHMGLSc8N16twM44bn4hit7voj4qvzaoqp
         C1l8WUyiU5+zP+O+u1hfSUqtg2DD4EBmB6mtZuMvSHr1MAtunADcdtB8pwDP8ZLfP3rZ
         G1Jmg0YaFVSDoW1VlBnE5O6IbbQTyb2jTL+aRfQSQzKefX6FIk/Kb9X/CT7Y12EVg3/i
         2FCM6aqALU3ZR6BcB59bjn2pM1lvo7CYo5vB8QSMexnDm0BbBxST8RFi4EO0MIiKfqSk
         nDl0DXj6s/hASCoph/yUIqwUZj91g9Thvkg025V0lIHn5a6nujkVy1B+kwZzf4qU2Cls
         jbxA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from;
        bh=A7tZCaYWus9D2ZS4daJYEMgBfuoBYxyWLPGiZSLMXaY=;
        b=s2HvdSwooGXh1F6R82zerwGDh4mWBxTqDCld4p1THwJHqm+quHWYBtGWMxoJ6MReTz
         060/+2VmeDMemLln4cx2y/VUvQsc24hT3Jz9efg9SpzLkDldp7uFiCYeLJsivJItFaXt
         4q4fVPFQQAajPQvcHyoz6sAUr0TU5+PjjnjFaDYE9oqHLJniil0kHi0FFqR1RuGoUVna
         bsBNk4eMHUDetpxZ5hcui3yfTT+gIjWKTAa1lSWEEpNyjBY0gofYBN7sVIo3+bZfC2r9
         cZEVhVgAbI5ACEk0mDeXMoA8kTxmArMpeb9Eyhzh7FENO7jQxD3kaQiP94czytZ/d1OL
         2miA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=s0CdCqEV;
       dkim=neutral (no key) header.i=@linutronix.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e24si1402025ejx.162.2020.09.25.01.01.36;
        Fri, 25 Sep 2020 01:01:59 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=s0CdCqEV;
       dkim=neutral (no key) header.i=@linutronix.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727736AbgIYIAZ (ORCPT <rfc822;deadfox.tw@gmail.com>
        + 99 others); Fri, 25 Sep 2020 04:00:25 -0400
Received: from Galois.linutronix.de ([193.142.43.55]:54494 "EHLO
        galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727464AbgIYIAZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Sep 2020 04:00:25 -0400
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1601020823;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=A7tZCaYWus9D2ZS4daJYEMgBfuoBYxyWLPGiZSLMXaY=;
        b=s0CdCqEVfAgOYDqpHWHxDBGEKwSHX+1gkF5gQASiD2bmpXqe9VQdR5ae6y2w+5VoqzjcuJ
        YRCydyDRW8j2IcQU2v28TVTfy8PpS4aHvPXbd4dLdA5qJC0I7TZDzukKW0QhmbAXe5SJ4W
        6fVDMo5Dv/RvVMI1fgkyuERnBHmbxTNCNh9NvxzlQpNK/y38IMi/SydTOG04ilX8tbcp5L
        uaSQMYUkjxepoQxarE4in0DGKjSpHWYtI1iXYNCZrL++C5lO2nMW9d00yjvMzxSh2k+q+5
        Z2rGL/savL5yayxjT84r+gaFJy38DyhQ79xtIS44aK/MXM9d5gmm84Na1mjZRA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1601020823;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=A7tZCaYWus9D2ZS4daJYEMgBfuoBYxyWLPGiZSLMXaY=;
        b=MD8ejMcwGoLzfPtsVHTldRLXKZseJkJfn7HfyFevNDP1cROrhEJ9LqOV8G7BI5BtPPrUz9
        8iNRm1Weh5PRYgDg==
To:     Kees Cook <keescook@chromium.org>,
        Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     luto@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-api@vger.kernel.org, willy@infradead.org,
        linux-kselftest@vger.kernel.org, shuah@kernel.org,
        kernel@collabora.com
Subject: Re: [PATCH v6 1/9] kernel: Support TIF_SYSCALL_INTERCEPT flag
In-Reply-To: <202009231349.4A25EAF@keescook>
References: <20200904203147.2908430-1-krisman@collabora.com> <20200904203147.2908430-2-krisman@collabora.com> <202009221243.6BC5635E@keescook> <874kno6yct.fsf@collabora.com> <202009231349.4A25EAF@keescook>
Date:   Fri, 25 Sep 2020 10:00:21 +0200
Message-ID: <87o8luuvze.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 23 2020 at 13:49, Kees Cook wrote:
> On Wed, Sep 23, 2020 at 04:18:26PM -0400, Gabriel Krisman Bertazi wrote:
>> Kees Cook <keescook@chromium.org> writes:
>> Yes, we can, and I'm happy to follow up with that as part of my TIF
>> clean up work, but can we not block the current patchset to be merged
>> waiting for that, as this already grew a lot from the original feature
>> submission?
>
> In that case, I'd say just add the new TIF flag. The consolidation can
> come later.

No. This is exactly the wrong order. Cleanup and consolidation have
precedence over features. I'm tired of 'we'll do that later' songs,
simply because in the very end I'm going to be the idiot who mops up the
resulting mess.

Thanks,

        tglx