Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp928303pxk; Fri, 25 Sep 2020 01:19:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwn5qjzVE+NM8jvjfaqMMv9Iyy/QiLPy6SO4w7yk65F8iKkLQZHE2NrAs5JNgAWPhhKAy4 X-Received: by 2002:a17:906:1a4b:: with SMTP id j11mr1521993ejf.97.1601021984519; Fri, 25 Sep 2020 01:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601021984; cv=none; d=google.com; s=arc-20160816; b=MlcrsFFnE+BIHyJL7h0mnwZ/8wHzRfw+G3nzj2wEVOCgjXhJwx1eAz24S2FuAAtU17 8DUdQiyBWfFMbIot5Y6xJTVHMWjpFcelsi5T68XvnqToYzTwWSkT5ZqaeQcS+AN18uwo 8rwImw7M0vjoxnMUpVQ+D+sGzPaFQBiu29k8PvQcT5cA0ZYkahaBALYMFDZ9YAUVuJsy 95gcbEMAezrNxZ1vbFLh6/c0e2hXXOVnGsre3GIn7343cfWM1hHo3UiBVN4VRPsA7vsQ ecAPIpO4gdE94Rs+HJFjXqEVpfXeZofhHxPeyBKySh4DofzVwjbfk+6WgKkXgt7PYsho dS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZgLaEQC68e3osNgfcIO9sC8Nptsdd/ClKs7+Bia7+kw=; b=dSrqbToXeiZZsjTaDb9Z9wPuDrgR43BxFYWKSG8T1X9NfAXTL+mzuwLOeZY9UTTUvs 2areVXio/vR3VQgkAmuJGe3QdMZ0atVCaG+rMS3txGdd5DWWxK4pssvf1ho9jWCE9ja0 NVmcVHpBhJ/4QxPCOz3gxPot5aVc2lqnMZp1b+yfsCI6kXzfOqKyahkKvJcFOPhjjt0R sI/I+MX8ca7lrrxL1rxnYHO0eUdsE5Q+8XgYcpt+/RTfjHH0RLXX40AadBtIdeIVrh5U fA02m4zg19UD1ph8Fgdsrh2zNaIzIkERL3G1LTbLiMpx2DCEES1L59XWKh7x/grSxfzw zwPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="F/txyV+e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si1262688ejx.195.2020.09.25.01.19.21; Fri, 25 Sep 2020 01:19:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="F/txyV+e"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727710AbgIYIQH (ORCPT + 99 others); Fri, 25 Sep 2020 04:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727063AbgIYIQH (ORCPT ); Fri, 25 Sep 2020 04:16:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34AC3C0613CE; Fri, 25 Sep 2020 01:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZgLaEQC68e3osNgfcIO9sC8Nptsdd/ClKs7+Bia7+kw=; b=F/txyV+eBo5XBPj0NJcZTnQdIq GNgRwctMGuVIVJZbmGpZgFenxsBE4CYdCw8MBhiea6kPhSZI7ydVJTY6/ldjFu3nBBEJm955Z7gRS XIoiYCcIQmxcrlJ8FoFffN5rVX0Zxz/oLboLPtUxwRSZ0K7azhuqOsn3VuoTgSSfgdqNIOx7fL15+ 7yBLhuSHc+BvUdtmnsdqnEH4bZWuFlU5+7E7WFDoZFs6fNDBRuYXl8XUsgpY1PqFKfYCsL8+RSvDQ ZCE/n3+2YVeFS5LDyaqZ3ZpMak7NvGBz48LIS+nFrC4W0w8cNMzeAoTZP/5Z5cjXhFRuZhQOo56HB kZevFGIQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLitV-0006lZ-Ij; Fri, 25 Sep 2020 08:15:53 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8280B302753; Fri, 25 Sep 2020 10:15:52 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 65EAF20BCC910; Fri, 25 Sep 2020 10:15:52 +0200 (CEST) Date: Fri, 25 Sep 2020 10:15:52 +0200 From: Peter Zijlstra To: Uladzislau Rezki Cc: Mel Gorman , "Paul E. McKenney" , Michal Hocko , LKML , RCU , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Thomas Gleixner , "Theodore Y . Ts'o" , Joel Fernandes , Sebastian Andrzej Siewior , Oleksiy Avramchenko , Mel Gorman Subject: Re: [RFC-PATCH 2/4] mm: Add __rcu_alloc_page_lockless() func. Message-ID: <20200925081552.GS2628@hirez.programming.kicks-ass.net> References: <20200921160318.GO12990@dhcp22.suse.cz> <20200921194819.GA24236@pc636> <20200922075002.GU12990@dhcp22.suse.cz> <20200922131257.GA29241@pc636> <20200923103706.GJ3179@techsingularity.net> <20200923154105.GO29330@paulmck-ThinkPad-P72> <20200923232251.GK3179@techsingularity.net> <20200924081614.GA14819@pc636> <20200924111907.GE2628@hirez.programming.kicks-ass.net> <20200924152112.GB19013@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924152112.GB19013@pc636> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 05:21:12PM +0200, Uladzislau Rezki wrote: > On Thu, Sep 24, 2020 at 01:19:07PM +0200, Peter Zijlstra wrote: > > On Thu, Sep 24, 2020 at 10:16:14AM +0200, Uladzislau Rezki wrote: > > > The key point is "enough". We need pages to make a) fast progress b) support > > > single argument of kvfree_rcu(one_arg). Not vice versa. That "enough" depends > > > on scheduler latency and vague pre-allocated number of pages, it might > > > be not enough what would require to refill it more and more or we can overshoot > > > that would lead to memory overhead. So we have here timing issues and > > > not accurate model. IMHO. > > > > I'm firmly opposed to the single argument kvfree_rcu() idea, that's > > requiring memory to free memory. > > > Hmm.. The problem is there is a demand in it: People demand ponies all the time, the usual answer is: No.