Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S278841AbRJaB3k>; Tue, 30 Oct 2001 20:29:40 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S278842AbRJaB3a>; Tue, 30 Oct 2001 20:29:30 -0500
Received: from [63.231.122.81] ([63.231.122.81]:1621 "EHLO lynx.adilger.int")
	by vger.kernel.org with ESMTP id <S278841AbRJaB30>;
	Tue, 30 Oct 2001 20:29:26 -0500
Date: Tue, 30 Oct 2001 18:28:10 -0700
From: Andreas Dilger <adilger@turbolabs.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Denis Zaitsev <zzz@cd-club.ru>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/main.c/root_dev_names - another one #ifdef
Message-ID: <20011030182810.B800@lynx.no>
Mail-Followup-To: Linus Torvalds <torvalds@transmeta.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Denis Zaitsev <zzz@cd-club.ru>,
	linux-kernel@vger.kernel.org
In-Reply-To: <E15yj2E-0001o7-00@the-village.bc.nu> <Pine.LNX.4.33.0110301610460.1336-100000@penguin.transmeta.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.4i
In-Reply-To: <Pine.LNX.4.33.0110301610460.1336-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Tue, Oct 30, 2001 at 04:12:36PM -0800
X-GPG-Key: 1024D/0D35BED6
X-GPG-Fingerprint: 7A37 5D79 BF1B CECA D44F  8A29 A488 39F5 0D35 BED6
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Oct 30, 2001  16:12 -0800, Linus Torvalds wrote:
> On Wed, 31 Oct 2001, Alan Cox wrote:
> > It took that out deliberately a few months back. The ifdefs in fact
> > break stuff
> >
> > Firstly the array is __init so is discarded on boot
> 
> I think that array really is broken. We should get the name association
> from the array that "register_blkdev()" maintains, I'm sure. That way
> random stupid driver X doesn't need to touch a common init/main.c file,
> which I find personally offensive.

I have a patch from way back (not mine) which allows the name to be
generated by the block device driver code.  Let me know if you are
interested.  This also fixes the ugly "lvma" "lvmb" devices that are
in /proc/partitions.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/