Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp974200pxk; Fri, 25 Sep 2020 02:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTufp7uPAonXYdUWPBauNUm7T6ExLVPAwfyQh4QrimAnWVDo/lOAOmKIRZNUrIPgdtv/5C X-Received: by 2002:a17:906:9941:: with SMTP id zm1mr1841843ejb.288.1601027629305; Fri, 25 Sep 2020 02:53:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601027629; cv=none; d=google.com; s=arc-20160816; b=S/YhYqZ+J6ffKgnXbISdTADy5Fosaq+zM2/sH3eb5bo8qAfPJP5IXw2PYQjspBwEdp VfGzxVVbmOkPq9pxdpMb8jH6QP7f9MwlsvWt9OgWaL/bUX8sZgaIpVr1wFf/J3nQsBfn ako+NzeSV01/RTLq2DWNIHZ4S6doEbCL3rJBECCUCkWKWhSSuIjB8AHVRBKGsfMF15Yx BqYTHjbHN+EinoVpXMTLrIzJL5VRLhg/ruO5rHERXe1P7QLQBiV+tgHAmxquK4ezX3M0 aK2yYFIVjLYP92F4XZ8usVBHwg+yiGRPEcbCcBLQUUUDV3Sfx9dtHlo9+AlkKCkTf8Q1 NZvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from:ironport-sdr :ironport-sdr; bh=u8Y8raxpv2dSyyfxtrEhhfuTDZfSvDESMe7TRakWVhk=; b=FK36gDsVqKE0oL7qOzXdymxnnjsvLU1GVQDnxuJa4LsSt7aBZcyu3p5i5/CgXM8aoZ hdik/WIQirkvkQnXc9WiHrXmhB+55a1ZOkug3fItFzc8GSrnJqWE1hgd8iXLq2+V+Nbx O5kKvio+/1IuG6hxYn11QbNdEFvo8eB054rYQrd1AeD9VhJAvd+sGF05Kxq2salxcnK9 8WdZg/p39COrgdVJ9v7zbjkHSoL2tOchXR6NtzS5MmM7fikUjeDfbn4HkGbMvrlvopZX inVcP6P+ILu/p8/4PiNzOLD1bq1EAvnZpeioHmCGXN1kpyGine/jc8Vp1MeET0FK3PlJ eqow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m20si1493774edv.189.2020.09.25.02.53.25; Fri, 25 Sep 2020 02:53:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727795AbgIYJwM (ORCPT + 99 others); Fri, 25 Sep 2020 05:52:12 -0400 Received: from mga07.intel.com ([134.134.136.100]:23483 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727290AbgIYJwM (ORCPT ); Fri, 25 Sep 2020 05:52:12 -0400 IronPort-SDR: AdVpkIc18TDQ0M8k1F1q9824CYU2UfG+aSdKw3TVkHEU7AHkGiy2ruqEz8ESHRQnJEfni0dobA 0mdJtX7WsjLA== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="225634026" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="225634026" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 02:52:11 -0700 IronPort-SDR: TrybvGWJmcvbbP21dLsqR2BSOs49k6JaoNa9vpYaiLY29F8SLJYjDkqXQDDJdcByDDf7zA40Ti xge0rwy/6tRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="487402522" Received: from glass.png.intel.com ([172.30.181.92]) by orsmga005.jf.intel.com with ESMTP; 25 Sep 2020 02:52:07 -0700 From: Wong Vee Khee To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ong Boon Leong , Voon Wei Feng , Wong Vee Khee , Vijaya Balan Sadhishkhanna , Seow Chen Yong , Mark Gross Subject: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path Date: Fri, 25 Sep 2020 17:54:06 +0800 Message-Id: <20200925095406.27834-1-vee.khee.wong@intel.com> X-Mailer: git-send-email 2.17.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While unloading the dwmac-intel driver, clk_disable_unprepare() is being called twice in stmmac_dvr_remove() and intel_eth_pci_remove(). This causes kernel panic on the second call. Removing the second call of clk_disable_unprepare() in intel_eth_pci_remove(). Fixes: 09f012e64e4b ("stmmac: intel: Fix clock handling on error and remove paths") Cc: Andy Shevchenko Reviewed-by: Voon Weifeng Signed-off-by: Wong Vee Khee --- drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c index 2ac9dfb3462c..9e6d60e75f85 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c @@ -653,7 +653,6 @@ static void intel_eth_pci_remove(struct pci_dev *pdev) pci_free_irq_vectors(pdev); - clk_disable_unprepare(priv->plat->stmmac_clk); clk_unregister_fixed_rate(priv->plat->stmmac_clk); pcim_iounmap_regions(pdev, BIT(0)); -- 2.17.0