Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1011083pxk; Fri, 25 Sep 2020 04:01:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhbsFGN37wBXjQ96y3FhVsMYcvH4crOiNw6asRvC+ftoGMRHzUoTJEz+NqP9pgNIjGzcXA X-Received: by 2002:a05:6402:1d03:: with SMTP id dg3mr616705edb.249.1601031676358; Fri, 25 Sep 2020 04:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601031676; cv=none; d=google.com; s=arc-20160816; b=fJCfyKBFQYx2VrGxRoOBuebjQrQ+wTKRUUKB+74gd1G6a2CbN7KkhZqSs5fXmXkeBj Am1YEE0RtTJzZu35G/6M5nrDKUpUalosdrts/lkxcfZVpmjQRz7D8i+XkL7x/ruyI9b8 My+FD1yL4O2Ed3CvdojC4f8VyZWLm4/QUMSqPsnCk71kkwqIKsZ4tdrc58vV5EaDu2Hn IKS1Qah9E4oNL12wlhZwBP7OmmATTPEgvSr8dPkwgNp8QA0W/MC4CM59K8BWb4DJPwDc 67ZW5SeSRGDYtEjGEt8EKCdC0Nhk7TeQzZItKxK/gDXimaFwoAjFno7x5H2LAr4IzR/E 2y6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=TDhsudWgea9w5ACe2BCNQFQRcLttqGTyBga1l9n+eVg=; b=QPkS9YakNE6IJ/sqohM7HE/lrpy0jOVJ+27n+3ReoaPO1OjwNZP7lN5JHTJVCGp7yz k3LkMpxir8VMkGsiyyOG4xs5UAw/G/2kaI5+ePW/nmWkrKCVkbRuUHnliiN0fN+ly/93 HHJztkArQ558M25LXb5Mqxs1uOc0B4cxPvW6YOWJLxeKhXiPJh6ql3bzGpQEUlEZd9lY dqNaVRYgF+VT7Yn3n7aFp4FJX5QmJx7QK8xVJpL21uiphpFt43mj2MVqWgQ6jc/BxvF/ j0V30Jz0VH7eeTftqpPRQ0Rv8GSBtWYTWoIYSMmmyw0q+HJfi/caQNJ5I2CCj6eqXuf0 HjGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si1862064ejf.387.2020.09.25.04.00.52; Fri, 25 Sep 2020 04:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbgIYK72 (ORCPT + 99 others); Fri, 25 Sep 2020 06:59:28 -0400 Received: from mga12.intel.com ([192.55.52.136]:23212 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbgIYK72 (ORCPT ); Fri, 25 Sep 2020 06:59:28 -0400 IronPort-SDR: NxroqJBFnnOG0SFW3jmr9GKFyorfexNZB+JKju4FRognpdMttbMXfIhW1gJIebzjfJDEiskCOk LAr0eFTqlESw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="140910441" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="140910441" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 03:59:27 -0700 IronPort-SDR: I5PGiilFQF4L2sIUVMB4EfcoM1xknhrv4qaJz1wLIa/x3ZofETSD99S2oTQ8tldgMaTF0/cdIi u3Af3IHcWobg== X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="487421891" Received: from tjhenson-mobl.amr.corp.intel.com (HELO localhost) ([10.252.48.117]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 03:59:21 -0700 Date: Fri, 25 Sep 2020 13:59:18 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: Sean Christopherson , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Jethro Beekman , Cedric Xing , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v38 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call Message-ID: <20200925105918.GB180915@linux.intel.com> References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com> <20200915112842.897265-22-jarkko.sakkinen@linux.intel.com> <20200924180407.GO5030@zn.tnic> <20200925003808.GB20333@linux.intel.com> <20200925081441.GF16872@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925081441.GF16872@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 10:14:41AM +0200, Borislav Petkov wrote: > > > > +#define SGX_ENCLAVE_RUN_EXCEPTION 4*8 > > > > + > > > > +#define SGX_SYNCHRONOUS_EXIT 0 > > > > +#define SGX_EXCEPTION_EXIT 1 > > > > > > Those are in ...uapi/asm/sgx.h too. Unify? > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > What about this here? Repeating myself, but since there is only 0 and 1, I would just use 0 and 1. Otherwise, I think I pretty much got these comments sorted out. /Jarkko