Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1032218pxk; Fri, 25 Sep 2020 04:36:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyb8kkkD4uKXwhzO0Wu5+f1VXJAVG89qOMeZP2B/AroKe12h62gf4J4Z6hjfq7bNLVhXXlz X-Received: by 2002:a50:c8cd:: with SMTP id k13mr777129edh.387.1601033791738; Fri, 25 Sep 2020 04:36:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601033791; cv=none; d=google.com; s=arc-20160816; b=Z1Bwh0pmN+Z3wSYiGeQmfkDg/y77Do1kEhixV1fobydNZhjS/Sov8PbXiCQ6OgLJgq ol1JqHDDrracBpvHMSGpJdwfOxM1vLYitferbsrhq0e/3S86QyEUjT1YvdeHTIe/klP3 tfpQ/CAZ/O8bI3RgiLPgjkpQlTwiLAUhf6gIzHEhARR76hSh1QzR2DPgqGOlFdOo4Zrj S+MGMKdxG3JQw5R3ZHMUzy/lYo0GGrB7GHTsPu4oV33PkBjaZWzWTNZB4Ek14k6Xs2i9 foUGx5xk50wnk81sRu0UmdFl4rJelK6AreyltUXTXa56pbgnNBihsyIFXFK5IuzEA5m4 X+NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=lQm9QaJvkFQmueovHJaTjaam7EM0oDZHCK0UYKhsEag=; b=a3dYnZa18NKNg/1RMWSXe9T7lUyDZBMPIG1l4WijVd9me8k5FC+WdcG66kxGPXxeMC zD3Z4GUTIf5V0FMEIivV42evKzc2hePAziEwGmEwRz26FprV9APJ/qymmr4Fp6Zc65yN 2jBJlNIEg0vrhuTeeCZPMw9R6AAgkMYPqioNN7mGktsNFx6zeg7jKZcwZHZmT62T3j97 3LkzdawwmSgooMJWwlR6np1zAPRQz1rYN7DYqzCw9QITIgWJobg7zApBy7CHqz5IGfXK D+tU9/RNF8i1G+FstbplEKqJh4xEaF4gsDHCTbcDEaNDPC1Mo9WsF+v3s5ppB/aKwaCX DMvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b1si1490049edw.229.2020.09.25.04.36.08; Fri, 25 Sep 2020 04:36:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728179AbgIYLfE (ORCPT + 99 others); Fri, 25 Sep 2020 07:35:04 -0400 Received: from muru.com ([72.249.23.125]:45416 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726990AbgIYLfD (ORCPT ); Fri, 25 Sep 2020 07:35:03 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 716C380B0; Fri, 25 Sep 2020 11:35:05 +0000 (UTC) Date: Fri, 25 Sep 2020 14:34:59 +0300 From: Tony Lindgren To: Andreas Kemnade Cc: khilman@kernel.org, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH v2] omap3: enable off mode automatically Message-ID: <20200925113459.GI9471@atomide.com> References: <20200911161209.25149-1-andreas@kemnade.info> <20200924090047.2b61f883@aktux> <20200924070550.GG9471@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924070550.GG9471@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [200924 07:06]: > * Andreas Kemnade [200924 07:00]: > > On Fri, 11 Sep 2020 18:12:09 +0200 > > Andreas Kemnade wrote: > > > > > Enabling off mode was only reachable deeply hidden > > > in the debugfs. As powersaving is an important feature, > > > move the option out of its shady place. > > > The debugfs file can still be used to override the default. > > > > > > Use the presence of a device compatible to ti,twl4030-idle or > > > ti,twl4030-idle-osc-off as an indicator that the board is wired correctly > > > for off mode. > > > > > > Signed-off-by: Andreas Kemnade > > > --- > > > An earlier version of this patch was here: > > > https://patchwork.kernel.org/patch/10794121/ > > > > > > A config option was used instead of the suggested devicetree check. > > > > > > Changes in v2: > > > - fix compile without CONFIG_ARCH_OMAP3 > > > The variable enable_off_mode is now always a real one and not > > > a preprocessor constant to avoid trouble with unusual configurations. > > > > > Anything I still missed here? > > No the missing part is just me picking up the remaining patches > for v5.10 that I'll hopefully manage to do today :) Applied now in omap-for-v5.10/soc thanks. Tony