Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 25 Sep 2020 14:21:15 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Li Heng <liheng40@huawei.com>, heikki.krogerus@linux.intel.com,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] usb: typec: Remove set but not used variable
Message-ID: <20200925122115.GD2680110@kroah.com>
References: <1600956767-10427-1-git-send-email-liheng40@huawei.com>
 <fe671faa-9975-be20-22f5-31a97e3c8859@roeck-us.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fe671faa-9975-be20-22f5-31a97e3c8859@roeck-us.net>
Precedence: bulk

On Thu, Sep 24, 2020 at 07:33:59AM -0700, Guenter Roeck wrote:
> On 9/24/20 7:12 AM, Li Heng wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> > 
> > drivers/usb/typec/tcpm/tcpm.c:1620:39: warning:
> > ‘tcpm_altmode_ops’ defined but not used [-Wunused-const-variable=]
> > 
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Li Heng <liheng40@huawei.com>
> 
> I thought there was a patch series underway which started using it,
> but maybe my memory defeats me. Either case, it doesn't make much sense
> to remove the ops variable without removing the associated functions
> as well.

I agree, if this isn't needed, then the functions here should also be
removed in the same patch.

thanks,

greg k-h