Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1083444pxk; Fri, 25 Sep 2020 05:57:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXFZ7QMl6ztjz4yP7TOvvJ2JSDib8ou6fc7WcBfs5n4qkDlcKbWj8KEwdAAOuYOV/dioOe X-Received: by 2002:a17:906:829a:: with SMTP id h26mr2633127ejx.11.1601038652526; Fri, 25 Sep 2020 05:57:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601038652; cv=none; d=google.com; s=arc-20160816; b=w0lmdbo2YcIeNbv6ohpyZQaodrvAJxtZAbgIILVDr/ujWH2XfTQl9l4PajAuhp7Lml 8tNOrKA09FHW+sOWGSZ4WiXr5cId2xK/NzhKmr355UN0+atHvrIYY8g35ixJ3zzawsuD Tk8uijKPxT58z0/VPqBVTw/26vePmOE4OOVlcsZ+0oPFMuG+d46HJypgMb9cKTrl/VSp yRPriYCqVatzwcvnUX7U0MC7woBodAf4vyRtGdTDNqJKU68Hpcou/GqSKrJndbVYoao9 OEoHxYoi11Y9Iud3AkJBGEttQSNxlmjRF+WIAoMq+/43jfRGoAVYTd98wFo9SJBwNezb yqNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wG6fv/NcXvsTIBDid3Wj5dQRVhU5mIwrdkHBzUagIVo=; b=JTzkHubDflNwGaU5PG6JbQUpzd4i+6KoQ2xA4RFgxgJAxh1JZQaB5fsIATXrE3XGq0 jeXHlzTA/yrQzuBy4dmH4iGdB5+exagqV+2wmVmZmGU/q1O+shoRxw+HotkFySJGuNpC Scg+/CVT2zrN7iW5USG5z78YEAk22RgNuRaM2yb8O3MXngIjW9rO4bm9Lur0fnGV/3nG zr+pWH0jKdEAd+KYjP3MpvhSLGhdQhBjTxW8wZlu/JF3Y+UbX/ByiuMeoMeeUu1YMTey 3T34EDnBv2EJ2DADXOI1fLhpv5oP/z4xZAV+XHw150XaTwSA1JRC/Xx0DKqPUVK0tCJ7 OLkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UZRXbzUv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si1986734edf.140.2020.09.25.05.57.08; Fri, 25 Sep 2020 05:57:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UZRXbzUv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729658AbgIYMzO (ORCPT + 99 others); Fri, 25 Sep 2020 08:55:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:34412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729260AbgIYMzG (ORCPT ); Fri, 25 Sep 2020 08:55:06 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FAC62072E; Fri, 25 Sep 2020 12:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601038506; bh=FsSVpHTo1XbS9P5HsjotCNgykMvxFWhHiexMQkxD/hM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UZRXbzUvysqD4SxbKAXx4fKHBnJ/LKH25K4HslYEdXoaGq4NfhSM5Vzutr26jll5v uHKUkyFSvXHugyInIN7UTxXGTADZyFdK31dE756l8Nz3/VItQb3dPTlPZyGyeY15QQ 1invxtL6Swn2izs4VAEWO+UZOMLd4rXSt8RP+Tzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Simon Horman , Jesse Brandeburg , "David S. Miller" Subject: [PATCH 4.19 14/37] nfp: use correct define to return NONE fec Date: Fri, 25 Sep 2020 14:48:42 +0200 Message-Id: <20200925124723.108622514@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200925124720.972208530@linuxfoundation.org> References: <20200925124720.972208530@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski [ Upstream commit 5f6857e808a8bd078296575b417c4b9d160b9779 ] struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0. Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Jesse Brandeburg Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c @@ -744,8 +744,8 @@ nfp_port_get_fecparam(struct net_device struct nfp_eth_table_port *eth_port; struct nfp_port *port; - param->active_fec = ETHTOOL_FEC_NONE_BIT; - param->fec = ETHTOOL_FEC_NONE_BIT; + param->active_fec = ETHTOOL_FEC_NONE; + param->fec = ETHTOOL_FEC_NONE; port = nfp_port_from_netdev(netdev); eth_port = nfp_port_get_eth_port(port);