Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200922132410.48440-1-yuehaibing@huawei.com>
In-Reply-To: <20200922132410.48440-1-yuehaibing@huawei.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Fri, 25 Sep 2020 16:12:01 +0200
Message-ID: <CAKfTPtBxrZUYsPsBrzNa4c5DF4X7gHknPTn_uZezkUtQoJZRCw@mail.gmail.com>
Subject: Re: [PATCH -next] sched: Remove unused inline function uclamp_bucket_base_value()
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 22 Sep 2020 at 15:24, YueHaibing <yuehaibing@huawei.com> wrote:
>
> There is no caller in tree, so can remove it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

> ---
>  kernel/sched/core.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 2d95dc3f4644..1b06b952dbbe 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -940,11 +940,6 @@ static inline unsigned int uclamp_bucket_id(unsigned int clamp_value)
>         return clamp_value / UCLAMP_BUCKET_DELTA;
>  }
>
> -static inline unsigned int uclamp_bucket_base_value(unsigned int clamp_value)
> -{
> -       return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value);
> -}
> -
>  static inline unsigned int uclamp_none(enum uclamp_id clamp_id)
>  {
>         if (clamp_id == UCLAMP_MIN)
> --
> 2.17.1
>