Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1208847pxk; Fri, 25 Sep 2020 08:51:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqT4a1ggaQrugW1rnY2TS0ljf26kvHsnEwhtMrCHBLdHnx3O9esTMj4+/Gok2kdhMuUKXs X-Received: by 2002:a17:906:4151:: with SMTP id l17mr3589158ejk.116.1601049099434; Fri, 25 Sep 2020 08:51:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601049099; cv=none; d=google.com; s=arc-20160816; b=dpWprp46EavU3CKaCG5JrtgwF07FWNkwelgZH1Hsmub+xT62XEbdFcQHbzkZFY+0ud fL3n8KlFzGx/CRL7AGD0lx1QHB8CL7+THCU3QTwUbkDXzvAPpJu+8EDKefSdmhQiFOEe utES9UcNGVFY2kb3BTxoLlBatHwLePgeTWiThD3AT7532t4T6fxYwEV2dzT5s2MFUaMS oKd4pI3lVaGGbQB2khCRm710WsHFaC9W6ScMEr6KHrVMFUO3MyTM8g4AGo/TcKbX/GMg 17KJOoT4sde24ttxswIAHAMQ8Ts76cvE+1nKSjncc5nyFogMSEe5DfpsDWQjnUnta0ma Fogw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=w2kX/aNAIl3MfdjSTDGtndCU165RLwxlOeyFa+cybJQ=; b=t+9mUSczcAZnw6rLGgeZktDbL9i7XCaoezaJUen/vsoGxpZ8vIAJpl1xmfvvt92SFm riFRoc7CmvkCkiRzS7UdUMPYwbW8FLLo+wvwHQew1ipAGFV3Urih4SmXH6VAgRkeWD3v zgwfLKTV84G7IoVKHNZBWO7TQgwNOhClpyM8MtWTvr6wpvgZHoXuXcI1mshVjqV4AfyH cwYp8VdfrS+NLCjetzSDg4wLOO/lKvSSA1kA0leatA1e4833nr1i0Q72QCF1oGJiiIMA tDIZG4KUwObY+CboY1v8nCitZqEkh/5FZRSr4tlvzXM2yBoC6mTu7kl57rJdRYKLS0Ha uDXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="oOZXjDT/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si2384232edi.441.2020.09.25.08.51.15; Fri, 25 Sep 2020 08:51:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="oOZXjDT/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729040AbgIYPuQ (ORCPT + 99 others); Fri, 25 Sep 2020 11:50:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:38562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727290AbgIYPuQ (ORCPT ); Fri, 25 Sep 2020 11:50:16 -0400 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1026235F9; Fri, 25 Sep 2020 15:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601049015; bh=iBYGy+tbYNUpVQgkRGaij6TxzblcvQfe+1AExVs5/v8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oOZXjDT/qPp5mqY7lbUO4oXvv98FICCthv1RDhtryOBmy8WnZ0OFPaUzUpRbnrJok qzH5O0wg/6LDICIUy0oEbHw5tedvkYnH+nqcBiqDESfnUyw0qEwKF3nCjtChxxztZk SqFGhP57wuQs6EBpWt6b8+whK/BSoJDoCM1Zoaoc= Received: by mail-ot1-f45.google.com with SMTP id u25so2736007otq.6; Fri, 25 Sep 2020 08:50:15 -0700 (PDT) X-Gm-Message-State: AOAM530P2cLSHtktVe/MpBF7+2jpEW2WvVRIITqIuhcvsfPPbDS520Po FvyctPUk63ZZggYZ/wHz8Pw0cqG2vkZ/wD1UDg== X-Received: by 2002:a9d:6b0d:: with SMTP id g13mr742522otp.129.1601049015126; Fri, 25 Sep 2020 08:50:15 -0700 (PDT) MIME-Version: 1.0 References: <20200925163435.680b8e08@xhacker.debian> <20200925163749.4a45b8fa@xhacker.debian> In-Reply-To: <20200925163749.4a45b8fa@xhacker.debian> From: Rob Herring Date: Fri, 25 Sep 2020 09:50:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled To: Jisheng Zhang Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Bjorn Helgaas , Ard Biesheuvel , PCI , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 2:39 AM Jisheng Zhang wrote: > > If MSI is disabled, there's no need to program PCIE_MSI_INTR0_MASK > and PCIE_MSI_INTR0_ENABLE registers. > > Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ domainshierarchical API") > Signed-off-by: Jisheng Zhang > Acked-by: Gustavo Pimentel > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Rob Herring