Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 25 Sep 2020 18:30:06 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Ivan Khoronzhuk <ivan.khoronzhuk@gmail.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        alexander.sverdlin@nokia.com, linux-kernel@vger.kernel.org,
        Ivan Khoronzhuk <ikhoronz@cisco.com>
Subject: Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and
 phy_stop
Message-ID: <20200925163006.GB3856392@lunn.ch>
References: <20200925124439.19946-1-ikhoronz@cisco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200925124439.19946-1-ikhoronz@cisco.com>
Precedence: bulk

On Fri, Sep 25, 2020 at 03:44:39PM +0300, Ivan Khoronzhuk wrote:
> To start also "phy state machine", with UP state as it should be,
> the phy_start() has to be used, in another case machine even is not
> triggered. After this change negotiation is supposed to be triggered
> by SM workqueue.
> 
> It's not correct usage, but it appears after the following patch,
> so add it as a fix.
> 
> Fixes: 74a992b3598a ("net: phy: add phy_check_link_status")
> Signed-off-by: Ivan Khoronzhuk <ikhoronz@cisco.com>
> ---
> 
> Based on net/master

Hi Ivan

In the future, please make the patch subject [PATCH net] to make it
clear which tree it is for.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew