Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161286AbWHDQ0m (ORCPT ); Fri, 4 Aug 2006 12:26:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161287AbWHDQ0m (ORCPT ); Fri, 4 Aug 2006 12:26:42 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:30907 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1161286AbWHDQ0m (ORCPT ); Fri, 4 Aug 2006 12:26:42 -0400 Message-ID: <44D3753B.1060403@sgi.com> Date: Fri, 04 Aug 2006 18:26:35 +0200 From: Jes Sorensen User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Andreas Schwab Cc: Alan Cox , Jeff Garzik , ricknu-0@student.ltu.se, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [RFC][PATCH] A generic boolean References: <1153341500.44be983ca1407@portal.student.luth.se> <44BE9E78.3010409@garzik.org> <1154702572.23655.226.camel@localhost.localdomain> <44D35B25.9090004@sgi.com> <1154706687.23655.234.camel@localhost.localdomain> <44D36E8B.4040705@sgi.com> <44D370ED.2050605@sgi.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 24 Andreas Schwab wrote: > Jes Sorensen writes: > >> We know that today long is the only one that differs and that >> m68k has horrible natural alignment rules for historical reasons, but >> besides that it's pretty sane. > > Try determining the alignment of u64 on i386. You will be surprised. If thats the case, then thats really scary :-( I'd claim it's a bug and I am willing to be that iptables isn't the only place that is affected or will be in the future. Would a fix along the lines of this work? typedef long long u64 __attribute__ ((aligned (8)); Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/