Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1399448pxk; Fri, 25 Sep 2020 13:49:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwlGidQKqdhEyYdFKbKuBxEcyvabNa40njZHlN2Q7qkKNQ2gYFhbyVG5wCBLwFsYGY9qKOs X-Received: by 2002:a17:906:9a1:: with SMTP id q1mr4497611eje.30.1601066942723; Fri, 25 Sep 2020 13:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601066942; cv=none; d=google.com; s=arc-20160816; b=Xa5/zgWKi6gqF6Nnvc0OU6IOdaMSI9KDTed8K/Ux+RLvkxhgz+6CDFZd/HT8wyBhR/ XLSk2qVz6UMQZj3FANJvFAwdJKH8KyLH/A88yIShoUUao7JA7KuRmyFK717WXcq10m2H ZnAWcBEKy1UsaYPzZc0pPmT2X5zUa8SnYzs4GTwxgMs9cJ2Rc+yKxRjZDPxG+mVe1GQF ifl+Qyif/uRxcqgxcBgO1owPmTnopAvlzZhaMqOVaRQx7vFsgSVblK3cK0kAeWpc6WoP TsD+fRkXbS9D2Z6874CaoEVkKxx009kg62WfAthhIoWA4P/X+5R5m87svf/VmYl2coM/ clcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=PvMww7z7d8oFO1quiIKNMd2v6sZn/RwadV2MREEICv4=; b=OPjejCuTXQmDLVmj6UTBOgeKlBsrqPClv+sWzhH+jdqH6r8VxX5jyRa7G3nNKG893u VLokPcqrQ/zwXm+xljrHGh9JykyEd5gAYLYZOMnrceqN138bxHOpk6E+wY/e8+kOMNgE gvzVyPbnvi+ZvfrtBGw4Kgh+upc/1+R6pSSJl/GYpBP2E5z8bFXXzEFX20UwOv0iQkvM 7HsRt1VhD4HpD5s0/sYcfiT5f8wZTJniiJ/S9iSYUu5NG6Jy27Dtg89qrAddTQeLmczG txK5SGbCfm6ndNKQa9VleAbh0vVeT1O5RXvYbVfWOq8ijViqkcL/+NcpQbM7uZWDmkqM Ndkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t7si2604826ejx.194.2020.09.25.13.48.40; Fri, 25 Sep 2020 13:49:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbgIYUpa (ORCPT + 99 others); Fri, 25 Sep 2020 16:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729060AbgIYUp0 (ORCPT ); Fri, 25 Sep 2020 16:45:26 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B900C0613CE; Fri, 25 Sep 2020 13:45:26 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BEB2B13B65D1E; Fri, 25 Sep 2020 13:28:37 -0700 (PDT) Date: Fri, 25 Sep 2020 13:45:22 -0700 (PDT) Message-Id: <20200925.134522.130367831393016171.davem@davemloft.net> To: mfwitten@gmail.com Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] openprom: Fix 'opiocnextprop'; ensure integer conversions; use string size From: David Miller In-Reply-To: <859f327c79da4d9c945e50568805456c@gmail.com> References: <20200914.170321.1710628974878239639.davem@davemloft.net> <859f327c79da4d9c945e50568805456c@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 25 Sep 2020 13:28:37 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Witten Date: Fri, 25 Sep 2020 20:20:20 -0000 > Are we trying to improve the code or not? Do you want me to apply your patch or not? I want to see the most minimal code change necessary to fix the bug, so we can easily backport it to -stable releases etc. If you want to perform a variable name or other similar cosmetic improvement, you can send a follow-up patch that does so. Thank you.