Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1414037pxk;
        Fri, 25 Sep 2020 14:15:25 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzxMBWLq5u5PchrJFFxckOMT84gjU1+caRuBWz8pJVd6NVAmluLko1safGaUNDWmGthqzy8
X-Received: by 2002:a17:906:fb84:: with SMTP id lr4mr4875462ejb.282.1601068525725;
        Fri, 25 Sep 2020 14:15:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601068525; cv=none;
        d=google.com; s=arc-20160816;
        b=gpjAdCZBEi9rEv1Y861a1UiQFbxj/tfZyBFJTDypW8c06VmveOAdO7rMl5GedLNMJv
         s/b5+/iDdlKGNzKNsbZOs9HRMlD3nmThNGdk7EbKfqHBrezkjVo85Dz1EUE7QAiZDRv5
         zf24QOYCDMXYGKnpeLmWjkqXlz+qcmm3V/pCKnULYmVzIE9nT5lnG1dygK/Lb6mVp2RS
         OS/imEAbJPVHq319vWYuApnVURHgcw2+ToGQjvhD9wm4ya6AIJXClkPJT7Cqx8aI2aNL
         at31QqL007oZ1jm+ZqbU3DQkagWh+ZHJyXo+Qm3mA9f2FZkQhT5vKFMoEkqxd2XXNwSB
         nd/g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=2d3eaxYIUTrXmEvX0gj5hWSEKwjNfU6puKsEZYToxXY=;
        b=URDScAb/Qdk7WVwcFrSrVAmXFrTYLw7/yArSjp6adomwk5P1Er5r+hjzQ9fz4hN74m
         JygEstgzBGPofuCtgKByIKkxhUoE7gDzPOo07Ur4tR8iEVIgw9QrHSZ8nVoDF9KHlikb
         nblF5KpIFuvvJtGR7UWUws3+8N76/RzdKK474EYGhRoO4DbP9K/qWu+A9OpjR2TKsCjz
         InSZxYMGKo4iZ4910lDfew5eDtJxCFUgI7mWrJTRM7qf4pHv8XNvf63MN9wTYtYIiLI9
         7rFlux3P8uNYgwcv4a8q10bwNSb/J/XgulVIXnfdGHQvhea9w20HNE4bci915YS+/0f8
         6pXg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e1si2644956edn.2.2020.09.25.14.15.03;
        Fri, 25 Sep 2020 14:15:25 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728051AbgIYVMf (ORCPT <rfc822;deadfox.tw@gmail.com>
        + 99 others); Fri, 25 Sep 2020 17:12:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726119AbgIYVMf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Sep 2020 17:12:35 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9523EC0613CE;
        Fri, 25 Sep 2020 14:12:35 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 8CF1113B70158;
        Fri, 25 Sep 2020 13:55:47 -0700 (PDT)
Date:   Fri, 25 Sep 2020 14:12:34 -0700 (PDT)
Message-Id: <20200925.141234.274433220362171981.davem@davemloft.net>
To:     f.fainelli@gmail.com
Cc:     netdev@vger.kernel.org, olteanv@gmail.com, vladimir.oltean@nxp.com,
        kuba@kernel.org, ap420073@gmail.com, edumazet@google.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: vlan: Avoid using BUG() in
 vlan_proto_idx()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200925002746.79571-1-f.fainelli@gmail.com>
References: <20200925002746.79571-1-f.fainelli@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 25 Sep 2020 13:55:47 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 24 Sep 2020 17:27:44 -0700

> While we should always make sure that we specify a valid VLAN protocol
> to vlan_proto_idx(), killing the machine when an invalid value is
> specified is too harsh and not helpful for debugging. All callers are
> capable of dealing with an error returned by vlan_proto_idx() so check
> the index value and propagate it accordingly.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes in v2:
> - changed signature to return int
> - changed message to use ntohs()
> - renamed an index variable to 'pidx' instead of 'pdix'

Applied, thanks Florian.