Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1419361pxk; Fri, 25 Sep 2020 14:27:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvWMQq2cpxmyIBs7m26Y5vdwjAkOPRCXVK657DEFdPQU8z2kuGwaWJYf9SrgkmtiN9mO/h X-Received: by 2002:a17:906:5809:: with SMTP id m9mr4672956ejq.304.1601069230634; Fri, 25 Sep 2020 14:27:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601069230; cv=none; d=google.com; s=arc-20160816; b=qnD+IKSNVhpqbfLiCmo3WMwfHkxOG9K3s3oxh/hAo7MBAVz8ITZjyuMHS+cwVibzIG pqbRBccoYqzgzwNmHMjXGyK6aZwICb6TZJK73CbEqTzSf0RXPHoIwXP+Gv3K7KWJk5lJ oiweitQuT7o7r4rL76uH/4la+LRIi8n2sNpLfEXcjorXF7+36+hSp3pR+W52qr5QI47Q 7/UsmPTZY2nzzA0XewE6B2y4eljVbyHa9Dpwa9hQovJYPhmgwwdfWqKRXtAptHGptW0t UcEvtwKKl4YmldisPbxJTIjFSzH+nwD14aKXxdy9NmKxN8wuoGzAYP9p00Znr0UA2s17 PTDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=riPiictfFiIPQJlTMTSKGVFjrTw+MUxj8C340DbapCg=; b=BK7AOhapAJFFcxOd7XU6dWu+korcLOcjvd7Pr4YndUoUuECCcxq9W7RoMJ+cLlWIIB 7RJCj34vGdPi4zZcUjPBXzIdVvG69zpDClosPIlnzeXDGO4Nu5R7u/Dwh8hfK6TW+A09 ava5euNy8dO9c81OCBbN6E2FXGJ+xERdiFpZz1Z/Vefpnujg6kVcuKxDnLF9hbw9ZuDj B5lnU2Sy+IClgEQJyzqaBNdcD7fz+nkt3vlcBA+9/6/p4+pbO8zVSCk/3ukK66R71vLv nUgoL8749RSH+TgGv7Ehwfu4Saq7abY1r3gFD0Y0BVnSTW7+ygBH5grFoPjHb/jtg+Du 6WuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B3aBd+Ju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d22si2638880edx.11.2020.09.25.14.26.48; Fri, 25 Sep 2020 14:27:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B3aBd+Ju; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729676AbgIYVZV (ORCPT + 99 others); Fri, 25 Sep 2020 17:25:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20583 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729587AbgIYVZJ (ORCPT ); Fri, 25 Sep 2020 17:25:09 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601069108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=riPiictfFiIPQJlTMTSKGVFjrTw+MUxj8C340DbapCg=; b=B3aBd+Jue2bvAbXjiEM1w6FNqfTOtmarFP/uinTcrEcl+kxzOKfW/unSbDOtcAzJ4Vp7ck /jYEHvh9MyybB5wHQ2yRAEsgQ9Rex7YSLqG4Szx2xt+kk0MEnOilkmht1LW+4+tRyfxtGS ybLhW4rKoJ+Hm0rfpmYnEYS9inxDN0g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-ms9hYRb3MtaUY-X-Ux-kXw-1; Fri, 25 Sep 2020 17:25:07 -0400 X-MC-Unique: ms9hYRb3MtaUY-X-Ux-kXw-1 Received: by mail-wr1-f72.google.com with SMTP id d9so1574440wrv.16 for ; Fri, 25 Sep 2020 14:25:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=riPiictfFiIPQJlTMTSKGVFjrTw+MUxj8C340DbapCg=; b=BsdwxizxaC568I6xvjlrReRogj1dWiC7pn3h5EvTNhcpemIQYoblM/s41njIS70q+p y4VO9BOfse2Jv8N4lYzOEOldblzlo9gVGDoFze1VObflkjnJVrggJHmOlG8tX45W6Jy8 lEaR3zYXYxZIZmU//+hshItZBE/Dzlmv3ZV1iF4/QINoZVrgAfJ88S0MykpSmwDRkj6y VfZtS93+DS5XeuppgE4wydgs2tv9fK7K6tgz1YkWELQw9clgavRItZ2+ew7CBR5aqIET eeOaYxLvPh+KgLdUMlxu+ira/VjApdR1J79Q/ulS+Zkmtpt2QNyPM+k0lt1fTbJ1G8UD Pifg== X-Gm-Message-State: AOAM5304Qyuj8ruIoV37EwQXdAVenC2p3DTg7Icd8FV1D6npJNRX1o+U MDI+kOtBg7vjnVSaximzuH+s7I3tiKgsd3h8xyFax2/Fy/NZ/LBB3OT+t4e47nbSKSAC6zhLrxb pCAXm+VeptuUYQajGE/esV9h0 X-Received: by 2002:a7b:c345:: with SMTP id l5mr467585wmj.123.1601069105672; Fri, 25 Sep 2020 14:25:05 -0700 (PDT) X-Received: by 2002:a7b:c345:: with SMTP id l5mr467575wmj.123.1601069105475; Fri, 25 Sep 2020 14:25:05 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ec9b:111a:97e3:4baf? ([2001:b07:6468:f312:ec9b:111a:97e3:4baf]) by smtp.gmail.com with ESMTPSA id h2sm4282661wrp.69.2020.09.25.14.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 14:25:04 -0700 (PDT) Subject: Re: [PATCH v2 6/8] KVM: x86/mmu: Rename 'hlevel' to 'level' in FNAME(fetch) To: Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Junaid Shahid References: <20200923183735.584-1-sean.j.christopherson@intel.com> <20200923183735.584-7-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: Date: Fri, 25 Sep 2020 23:25:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200923183735.584-7-sean.j.christopherson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/09/20 20:37, Sean Christopherson wrote: > Rename 'hlevel', which presumably stands for 'host level', to simply > 'level' in FNAME(fetch). The variable hasn't tracked the host level for > quite some time. One could say that it stands for "huge" level... I am not too attached to it, the only qualm is that "level" is usually used as the starting or current level and rarely as the end level in a loop. But then it's used like that in __direct_map, so... Paolo