Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1488747pxk;
        Fri, 25 Sep 2020 16:51:23 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJybfDkmtVJgLqWM3lDHBQvp43udSXicTwssdCsqsq4QB/VnQX6+paaFKif8IKSSUk8rOJch
X-Received: by 2002:a17:907:10db:: with SMTP id rv27mr4995137ejb.223.1601077882952;
        Fri, 25 Sep 2020 16:51:22 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1601077882; cv=none;
        d=google.com; s=arc-20160816;
        b=d7dkFs32pxO63A9u6sgEY3ABjhFCCmgOdjM/RDK1FhhqfxzmE6f5Ms6gNmPb1MDWk6
         oUAYzAIQEjNXggkic+fsrhLaXM818c+k13mi2WnG//Pe8jTUzR7hxIu4Zg5vJcD7jlf8
         Y6ATt4LYUiXM80VGbQZGFjpikmxnke1fx9P4/sdf8WfQmrizsMDwW4XFUy7PpgpEyO3x
         Y0izB494Gt1txKtojqV0yDB7ts1zS1/u4EGwwxz8VMIH/OXrA4VlP2AQrGY1XYtF5zgf
         YFWR7HGc32FBTvSoGKOA98n4bmFA6MYdhDeZFyD38KRYDkyVvmTPAXxYg9GrDtpmdtpC
         F81g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=YEl4YFq0raaq+LmCSICHIHrwLt/ZHPLI0QhuKD+A9vU=;
        b=JzYtAzJBLd9xe9hltKlxZtbJeSakNeEXOW9SeOHWjz7J+lJbBdGWXMPb8uyCThLZPj
         tSOVK3qNhPnS19Q7SzsKiNb3lcuY4bXJl/BvBHfq5I/eNrkaZXOWeqz65mE+Z7ahC1LS
         L/vRl7EXKWBB16ghn0O2CXoA7j3IX5fe1WzyZcv4yv8yNoW5hU44G8YR5ivFgXbLGfqk
         inwGREO2iClqmlyg+cCH5wzFjGeJTgsMhHteHgkxYvatTmByvccnumUU8Fgh49G5PsO1
         Y3+neYPJE7giZHGPekM2a9Mt3qvAUhSLUffvqRe9DIL+Iq9o229i1J2OnHFTrV7l68bp
         +zUQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id u8si2973066edx.66.2020.09.25.16.51.00;
        Fri, 25 Sep 2020 16:51:22 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729810AbgIYXtm (ORCPT <rfc822;deadfox.tw@gmail.com>
        + 99 others); Fri, 25 Sep 2020 19:49:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56366 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726037AbgIYXte (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Sep 2020 19:49:34 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39CDDC0613CE;
        Fri, 25 Sep 2020 16:49:34 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 2168213BA091A;
        Fri, 25 Sep 2020 16:32:46 -0700 (PDT)
Date:   Fri, 25 Sep 2020 16:49:32 -0700 (PDT)
Message-Id: <20200925.164932.397279241814019073.davem@davemloft.net>
To:     vee.khee.wong@intel.com
Cc:     peppe.cavallaro@st.com, alexandre.torgue@st.com,
        joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        andriy.shevchenko@linux.intel.com, boon.leong.ong@intel.com,
        weifeng.voon@intel.com, sadhishkhanna.vijaya.balan@intel.com,
        chen.yong.seow@intel.com, mgross@linux.intel.com
Subject: Re: [PATCH net 1/1] net: stmmac: Fix clock handling on remove path
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200925095406.27834-1-vee.khee.wong@intel.com>
References: <20200925095406.27834-1-vee.khee.wong@intel.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 25 Sep 2020 16:32:46 -0700 (PDT)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wong Vee Khee <vee.khee.wong@intel.com>
Date: Fri, 25 Sep 2020 17:54:06 +0800

> While unloading the dwmac-intel driver, clk_disable_unprepare() is
> being called twice in stmmac_dvr_remove() and
> intel_eth_pci_remove(). This causes kernel panic on the second call.
> 
> Removing the second call of clk_disable_unprepare() in
> intel_eth_pci_remove().
> 
> Fixes: 09f012e64e4b ("stmmac: intel: Fix clock handling on error and remove paths")
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Voon Weifeng <weifeng.voon@intel.com>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com>

Applied, thanks.