Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1489127pxk; Fri, 25 Sep 2020 16:52:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy76VgKg3I5rxgQdiPtNSoqEgJAV2peeP6wyN5CeX69WW5EQBGZ3RqRztYDJuxLGQRRTDfx X-Received: by 2002:a17:906:4553:: with SMTP id s19mr5011541ejq.475.1601077937444; Fri, 25 Sep 2020 16:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601077937; cv=none; d=google.com; s=arc-20160816; b=txmj4IifEhh2ZeEd6fPACca5EkrcF9OkHpLj6hr47UYKOaA8IU6cHLNEklyasFDlvD 33YzPNymeM9zxSym1zPUJvL7Q74uhYnBOU437Qif2bI6hd9og7Qg4RpL1nWNOhFAGaKV 5G9pfBRtOqXNepzks2YRktNfj7gBAOsKxbTrqaEpxqYQ9M7VRZsTVRFrmOptIFXHjVVA rF7wdZuoADEc6VVuB1Zs1TiK0LLJ7f/VVqEBe+VGSCy+PrC6Lo5FIkaWR4ikxBZgYUCL mn6zmjPn8UTHkhNhwhxe9xOhTZ5wTdYRITw/NHmIyATbROttoBsKodAd9cc4Ji4oV6nB /7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=GfAjzYpvzXjmi87tcxPpWjdbb2BOqtsmnBF/0nq3rzg=; b=BVJN0kOJw6KVd9gl5+5JNrohd8T0gvuEWnHF6IqSX3nNRUOBIy9JTD3zIzZc1IlkoV tW0EVMCSoX9c4h4+RyVYfQsaBaLwE6+xaxPqM5Gal2r0+LPbj+qgYY5Huw0OVlO+Q4/E +/X0pYXwJ9ty1xGJZh+UqRWkX/eRAFWEiD7E8iDxHB9UTHCAazg4P/YGc6D312iQHC2S GDsuRkatPIPCrpsGOUAtkKVwy3eE5/x6ZDxfF9YDFZrYIZ3vQWUwNXtEnW4/Gvi5+Pfk wixEFWelGRfpDAhhoclRqqC3ZK84gy7BuwsBOFMVKG6J8VrNxqdPKbZyLBA/C9PhNzbL c06w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C4C+uK+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x23si2803604ejc.63.2020.09.25.16.51.54; Fri, 25 Sep 2020 16:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C4C+uK+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729424AbgIYXu5 (ORCPT + 99 others); Fri, 25 Sep 2020 19:50:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728780AbgIYXu5 (ORCPT ); Fri, 25 Sep 2020 19:50:57 -0400 Received: from [192.168.0.112] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1307A20866; Fri, 25 Sep 2020 23:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601077856; bh=GfAjzYpvzXjmi87tcxPpWjdbb2BOqtsmnBF/0nq3rzg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=C4C+uK+Q8QeDxc9+hwrzC501NMnw0U9kZGHyapjODn5eIDLLrcwrVaIKoG4c2Qk0A rn3RpGFD1iM0Y9CgL99qEWmuzfAsLkMVkyvLyXu09S9Q9RTzsQa++njJxd/zi5MHo4 Ce6/mSVPVUAi1BEBfo2PpWiZYfKQGRJNztahW1qw= Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call To: "Kuppuswamy, Sathyanarayanan" , Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, Jay Vosburgh References: <20200922233333.GA2239404@bjorn-Precision-5520> <704c39bf-6f0c-bba3-70b8-91de6a445e43@linux.intel.com> <3d27d0a4-2115-fa72-8990-a84910e4215f@kernel.org> <526dc846-b12b-3523-4995-966eb972ceb7@kernel.org> <1fdcc4a6-53b7-2b5f-8496-f0f09405f561@linux.intel.com> <95e23cb5-f6e1-b121-0de8-a2066d507d9c@linux.intel.com> <65238d0b-0a39-400a-3a18-4f68eb554538@kernel.org> <4ae86061-2182-bcf1-ebd7-485acf2d47b9@linux.intel.com> <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: <1bbbdfde-2493-7ff5-fd13-b6340b1228e7@kernel.org> Date: Fri, 25 Sep 2020 19:50:55 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8beca800-ffb5-c535-6d43-7e750cbf06d0@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/25/2020 2:16 PM, Kuppuswamy, Sathyanarayanan wrote: >> One approach is to share the restore code between hotplug driver and >> DPC driver. >> >> If this is a too involved change, DPC driver should restore state >> when hotplug is not supported. > Yes. we can add a condition for hotplug capability check. Now that I think about this more... This won't work. Link is brought down automatically by the DPC hardware. Therefore, all software state is lost. Restore won't help here. The only solution I can see is to force driver disconnect and rescan.