Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 25 Sep 2020 16:55:16 -0700 (PDT)
Message-Id: <20200925.165516.1977040744847893527.davem@davemloft.net>
To:     ivan.khoronzhuk@gmail.com
Cc:     netdev@vger.kernel.org, kuba@kernel.org,
        alexander.sverdlin@nokia.com, linux-kernel@vger.kernel.org,
        ikhoronz@cisco.com
Subject: Re: [PATCH] net: ethernet: cavium: octeon_mgmt: use phy_start and
 phy_stop
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200925124439.19946-1-ikhoronz@cisco.com>
References: <20200925124439.19946-1-ikhoronz@cisco.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Ivan Khoronzhuk <ivan.khoronzhuk@gmail.com>
Date: Fri, 25 Sep 2020 15:44:39 +0300

> To start also "phy state machine", with UP state as it should be,
> the phy_start() has to be used, in another case machine even is not
> triggered. After this change negotiation is supposed to be triggered
> by SM workqueue.
> 
> It's not correct usage, but it appears after the following patch,
> so add it as a fix.
> 
> Fixes: 74a992b3598a ("net: phy: add phy_check_link_status")
> Signed-off-by: Ivan Khoronzhuk <ikhoronz@cisco.com>

Applied and queued up for -stable, thanks.