Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1503738pxk; Fri, 25 Sep 2020 17:24:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPCHyR3BqYKV5YPXhNMP+Sz2bBLQ6xvBnRUAZ4WFnluTHGzX5Pvj3rfehHrPXDl1GXxUP9 X-Received: by 2002:a17:906:2458:: with SMTP id a24mr5493365ejb.353.1601079877535; Fri, 25 Sep 2020 17:24:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601079877; cv=none; d=google.com; s=arc-20160816; b=rSLkanX3C84Mg49jRLT2NewpgtmS2Qr1cKbm/jEKTFtYcwyQVWPA9dSDWKpj7TeZb5 YoqDRSPnXDG+m4OBcM/5qVSWfctLpipOeuysO9e3oKr1+NrP4X1YhlbMVaE4QZBJLg2O KPRhf5+mxiyREDTsb7w/s3uC5VPgJYjle7Ism/IP2PJ1KpQozLvf0dypYPkTfXXqiz3p yDATktRpOzkieiGbiuuyz9g1uzHGv3Z4O+fZpKTUMFXjH92ChD4jh/KB+J//GsGdke7/ cCiLUqLOHbRuI4qgeK8CT1S+1fcYynRteNQOQ99bMbKc5rPvpAtH1YgievvYnisLJNYm 8Myg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=rBlE3tvrZRcR07h4TdGkfa39W1mZMtw8tbkErf6purU=; b=xTViA1OfMe7itls8+UsRT+VwPpPbC5+frYi3CkG2mWhRCa3TsXSy3fTZfcAeYEsLel 06vKVQNfKnWk7kb60KS9CfHGeh2gd5SIqLODduZSFkDhjTx+oew63ixTdV1nxel9M7uK oTDj8We8Hpm/xGnK8Oa+PvsGd7DUr0Q6mY90nz/of7JD8+8oLbIWTp91x93nmBNn3sv3 JpLi2r01HPWcGQ42F8XdDmco8Yjz/a0ohq2TPh+WluBQ8Vsqi5IT3RVlV8ZU710Dejsj RN9zrvF+r6uCpmeP1LPGe522JCj0ae/fTLs51H4rEIbCISVPaG3ZKeTI1RJl3UzZaSwC ayYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WHgze79J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si2965493ejo.316.2020.09.25.17.24.14; Fri, 25 Sep 2020 17:24:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WHgze79J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729623AbgIZAW7 (ORCPT + 99 others); Fri, 25 Sep 2020 20:22:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20068 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729186AbgIZAW7 (ORCPT ); Fri, 25 Sep 2020 20:22:59 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601079777; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rBlE3tvrZRcR07h4TdGkfa39W1mZMtw8tbkErf6purU=; b=WHgze79JyEJkk856HDx3OoJAoTZsX4fUZRP2hiyU1Y4UQBpP6fWpYmoKi1iZRS1I3/V98X +AFKLSCU5rA7A6nu22uk5XJyI3hg5Ugiw/Xa1/RbRVUKyXo6pbrtqRuQnG+JJxVbNwiRlh DQf3yib5XqAGT4AZo4oOYN3XM+jV5Kc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-rDalYjPtPa-bpFiw8cXJwQ-1; Fri, 25 Sep 2020 20:22:53 -0400 X-MC-Unique: rDalYjPtPa-bpFiw8cXJwQ-1 Received: by mail-wr1-f70.google.com with SMTP id s8so1715398wrb.15 for ; Fri, 25 Sep 2020 17:22:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rBlE3tvrZRcR07h4TdGkfa39W1mZMtw8tbkErf6purU=; b=kMzGWvCzhktKiHix1VFW8XOCerMeZFKY5Jxfca14LzjFN6zDjyM5+SOmtaJ+7vUK4T YbAkMAnzSv0xQtORY8i4n58KGpiK+MTTEsKoxNZ+2A4j/EJMCCPk+zvXbP3cGu8KLpk0 LSdb7AoMB8FK5vTUtTtkyTOj8fqHff+oTLHj60v0xsk3kmjf4ZVF2zuvpVX5gVeB+S5v qUglT6SnadDkx5NCjRG0NfX8H++vMMzA0TUxOGCP8yigz/x/y6XMCWeWXSZJqzlYnlmM B2fq0+hGgL+FJJj2AzbNYdHNmzbIozKbGppMBeD4FbqhQvDe2lj0VyFU5sawZM2AiThe W3aw== X-Gm-Message-State: AOAM533Sqp5pEycQsAYvLyq9YSFgTrRfxuNSzg/bKl9RL3U1dTRErt9s ElIz7Bb4LQdf8RMRaysEyBw5yGbR4IJaVtfaLlgC85RMrH8SVd9lvs4noCkypxDhwNMPbXJYq7t 1lIhd15sbYfvzQ1n0GQuhjKJ7 X-Received: by 2002:a7b:ca56:: with SMTP id m22mr136192wml.12.1601079772162; Fri, 25 Sep 2020 17:22:52 -0700 (PDT) X-Received: by 2002:a7b:ca56:: with SMTP id m22mr136161wml.12.1601079771862; Fri, 25 Sep 2020 17:22:51 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ec9b:111a:97e3:4baf? ([2001:b07:6468:f312:ec9b:111a:97e3:4baf]) by smtp.gmail.com with ESMTPSA id c14sm4503667wrm.64.2020.09.25.17.22.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 17:22:51 -0700 (PDT) Subject: Re: [PATCH 11/22] kvm: mmu: Factor out allocating a new tdp_mmu_page To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Cannon Matthews , Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-12-bgardon@google.com> From: Paolo Bonzini Message-ID: <66db4185-d794-4b3e-89c2-c07f4f2b5f2a@redhat.com> Date: Sat, 26 Sep 2020 02:22:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200925212302.3979661-12-bgardon@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/20 23:22, Ben Gardon wrote: > Move the code to allocate a struct kvm_mmu_page for the TDP MMU out of the > root allocation code to support allocating a struct kvm_mmu_page for every > page of page table memory used by the TDP MMU, in the next commit. > > Tested by running kvm-unit-tests and KVM selftests on an Intel Haswell > machine. This series introduced no new failures. > > This series can be viewed in Gerrit at: > https://linux-review.googlesource.com/c/virt/kvm/kvm/+/2538 Maybe worth squashing into the earlier patch. Paolo