Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1504468pxk; Fri, 25 Sep 2020 17:26:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoQ4LUU0QGitWnUQ4sDcsRgeXYlxtPyeO3pirLw6jFxKL67/i1nFBfiveL22KKBePDh7oR X-Received: by 2002:a05:6402:b1a:: with SMTP id bm26mr4151582edb.209.1601079987789; Fri, 25 Sep 2020 17:26:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601079987; cv=none; d=google.com; s=arc-20160816; b=eJHbKF2vabaeTKLbrJZ9xU5DOhZCS8To1KbSuil+YIc5sZlj6oXLD2q2I9huNvEYyp vpr588gzZE4Ez3OVE2GxLTi6tdJaeBRpnrtDA8vAnWYwcZ7AZbU3q5kxFOrh6VyMdTyv xPBY3fJzw+iQ98koWzSM9oQWwmawA2by8jnHbKZO1P56P/ZCk6kvCtG8+fEk0h5j2Lry VEp40bsG787KV2/JTUP1oMcHi2zCgnyQTpqNgmO67QohEgvNQb61JFTqyrb9t5MLUbUc XrUMTD8CW1ZiFesrXiYujgDbozHhiSLrMZXVIzyp4rNmNwSovIw4xNd3PgwpgxydXn/0 g5HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=HTbkQv9ToVq5Nb6qFL5vX3aJCuo5OQrcsX4p0Kd2ypk=; b=V+p1znBCQC8poblqmLt7XUNpvcBOEuc5CNaLOgbXnbfs7rVpd1dLrVauLoAwykie9t tT3PczdF2SQlCsDIy26L7Pg5awRGKiAGxy72UhdSSS3dNtD36Ne5A9MG5PA6ojg0D1bF AU+JseOeOsY/9LrXmSjF56JdN+sIx/4RwBRvWLtossZY13lN8JYxX8awzBLEYpNrS+ig 8e7uCeBmZ0MfcHCQD31l3psEK9+y2ygHWB8KHyYDn2upXlOhr9MCFJVlsc1neqlJdOEQ 3eztnKL2wIYzmiYiJK9RwMakhLW2IoO34JdihDOm2nuGG46pgAV+XS0gKjEjHBNm1oqQ AdoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cl5spbH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kt8si3033137ejb.503.2020.09.25.17.26.04; Fri, 25 Sep 2020 17:26:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cl5spbH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729701AbgIZAYV (ORCPT + 99 others); Fri, 25 Sep 2020 20:24:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48192 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbgIZAYV (ORCPT ); Fri, 25 Sep 2020 20:24:21 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601079859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTbkQv9ToVq5Nb6qFL5vX3aJCuo5OQrcsX4p0Kd2ypk=; b=cl5spbH2TY+igwtvhj1hzAqGXSwezIklOFUA1rwAywXaDK6a2MeSOz5na4h3LiObnt0/Fs 04tGMSbWKi8mm3MWaAFdjt2F2ulo5iI5y9V94pWbboJVWKKoyfDAYfweD9C8uE+ZKY7uZh B+cVGRFCRnw/1Uz0p/6x7YsbGxGqli8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-drhDz9LPPZmF2FdyCRQpYw-1; Fri, 25 Sep 2020 20:24:18 -0400 X-MC-Unique: drhDz9LPPZmF2FdyCRQpYw-1 Received: by mail-wr1-f70.google.com with SMTP id w7so1740790wrp.2 for ; Fri, 25 Sep 2020 17:24:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HTbkQv9ToVq5Nb6qFL5vX3aJCuo5OQrcsX4p0Kd2ypk=; b=SWDOZvZf/54og55idWu9FBHC9VypEgSaJXYUJ3IgqPzj3oTCxMKLUIcweuz0YuRsoY PPpp87Hp37uYBhI7ZJq4n7cxTbFWzzvN55zSyVcTbrZBNZ9kACAjJhGpoZ+qY4++RzSM lxOR5/6T0CyTMk34bWt/dO3ytDOv0/jG+7Nga2Z8CdXZfkvKhT8yPSOquk404Y2UfBgY bV90tCx+QQqud2R7Fw1lDpcJBe2HWpgSgsL9Eo/Q0YqoQGM7cfGtknaTeH8w0YrOrxaa tI10kmQlK/niLdrLnMgkC/pNK7i2pkCbLlgT+rMYwZ8HkJretohXxcdjUQGb4RK6VHw5 aKgQ== X-Gm-Message-State: AOAM530xUB4IJ1B8GR5fs0Yy9i0O81wJS4f7t/bkaZoBk3CPRFjF+jOm a7HlpVwbtFqzP+RD1EVAhb8vS4AHnyD0ubenwWOVUHxdqtSSd6XfN7gIvjPiJAGZciyzGvCf8S9 tz0hzKfMVtm7j+yPKtCEZ1d+K X-Received: by 2002:adf:ffc7:: with SMTP id x7mr6906346wrs.405.1601079856917; Fri, 25 Sep 2020 17:24:16 -0700 (PDT) X-Received: by 2002:adf:ffc7:: with SMTP id x7mr6906333wrs.405.1601079856737; Fri, 25 Sep 2020 17:24:16 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ec9b:111a:97e3:4baf? ([2001:b07:6468:f312:ec9b:111a:97e3:4baf]) by smtp.gmail.com with ESMTPSA id n21sm660473wmi.21.2020.09.25.17.24.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2020 17:24:16 -0700 (PDT) Subject: Re: [PATCH 10/22] kvm: mmu: Add TDP MMU PF handler To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Cannon Matthews , Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20200925212302.3979661-1-bgardon@google.com> <20200925212302.3979661-11-bgardon@google.com> From: Paolo Bonzini Message-ID: <91269bc5-ddef-9ede-774a-9a07d4ceb675@redhat.com> Date: Sat, 26 Sep 2020 02:24:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200925212302.3979661-11-bgardon@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/09/20 23:22, Ben Gardon wrote: > > -static bool is_nx_huge_page_enabled(void) > +bool is_nx_huge_page_enabled(void) > { > return READ_ONCE(nx_huge_pages); > } > @@ -381,7 +361,7 @@ static inline u64 spte_shadow_dirty_mask(u64 spte) > return spte_ad_enabled(spte) ? shadow_dirty_mask : 0; > } > > -static inline bool is_access_track_spte(u64 spte) > +inline bool is_access_track_spte(u64 spte) > { > return !spte_ad_enabled(spte) && (spte & shadow_acc_track_mask) == 0; > } > @@ -433,7 +413,7 @@ static u64 get_mmio_spte_generation(u64 spte) > return gen; > } > > -static u64 make_mmio_spte(struct kvm_vcpu *vcpu, u64 gfn, unsigned int access) > +u64 make_mmio_spte(struct kvm_vcpu *vcpu, u64 gfn, unsigned int access) > { > > u64 gen = kvm_vcpu_memslots(vcpu)->generation & MMIO_SPTE_GEN_MASK; > @@ -613,7 +593,7 @@ int is_shadow_present_pte(u64 pte) > return (pte != 0) && !is_mmio_spte(pte); > } > > -static int is_large_pte(u64 pte) > +int is_large_pte(u64 pte) > { > return pte & PT_PAGE_SIZE_MASK; > } All candidates for inlining too (Also probably we'll create a common.c file for stuff that is common to the shadow and TDP MMU, but that can come later). Paolo