Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 26 Sep 2020 17:46:35 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Pavel Machek <pavel@denx.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Kfir Itzhak <mastertheknife@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 4.19 23/37] ipv4: Update exception handling for multipath
 routes via same device
Message-ID: <20200926154635.GA3347445@kroah.com>
References: <20200925124720.972208530@linuxfoundation.org>
 <20200925124724.448531559@linuxfoundation.org>
 <20200925165134.GA7253@duo.ucw.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200925165134.GA7253@duo.ucw.cz>
Precedence: bulk

On Fri, Sep 25, 2020 at 06:51:34PM +0200, Pavel Machek wrote:
> Hi!
> 
> > [ Upstream commit 2fbc6e89b2f1403189e624cabaf73e189c5e50c6 ]
> > 
> > Kfir reported that pmtu exceptions are not created properly for
> > deployments where multipath routes use the same device.
> 
> This is mismerged (in a way that does not affect functionality):
> 
> 
> > @@ -779,6 +779,8 @@ static void __ip_do_redirect(struct rtab
> >  			if (fib_lookup(net, fl4, &res, 0) == 0) {
> >  				struct fib_nh *nh = &FIB_RES_NH(res);
> >  
> > +				fib_select_path(net, &res, fl4, skb);
> > +				nh = &FIB_RES_NH(res);
> >  				update_or_create_fnhe(nh, fl4->daddr, new_gw,
> >  						0, false,
> 
> nh is assigned value that is never used. Mainline patch removes the
> assignment (but variable has different type).
> 
> 4.19 should delete the assignment, too.

Ah, good catch, I'll merge this in, thanks.

greg k-h