Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1601103820-14002-1-git-send-email-wangqing@vivo.com>
In-Reply-To: <1601103820-14002-1-git-send-email-wangqing@vivo.com>
From:   Guenter Roeck <groeck@google.com>
Date:   Sat, 26 Sep 2020 10:11:25 -0700
Message-ID: <CABXOdTcTBHhxDfnrAFMLZ7fVPq2p6rPMTFceAkRNN4SKvvC1FQ@mail.gmail.com>
Subject: Re: [PATCH] chrome: Use kobj_to_dev() instead
To:     Wang Qing <wangqing@vivo.com>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Sep 26, 2020 at 12:03 AM Wang Qing <wangqing@vivo.com> wrote:
>
> Use kobj_to_dev() instead of container_of().
>
> Signed-off-by: Wang Qing <wangqing@vivo.com>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/platform/chrome/cros_ec_sysfs.c | 2 +-
>  drivers/platform/chrome/cros_ec_vbc.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b/drivers/platform/chrome/cros_ec_sysfs.c
> index d45ea5d..a643ea8
> --- a/drivers/platform/chrome/cros_ec_sysfs.c
> +++ b/drivers/platform/chrome/cros_ec_sysfs.c
> @@ -326,7 +326,7 @@ static struct attribute *__ec_attrs[] = {
>  static umode_t cros_ec_ctrl_visible(struct kobject *kobj,
>                                     struct attribute *a, int n)
>  {
> -       struct device *dev = container_of(kobj, struct device, kobj);
> +       struct device *dev = kobj_to_dev(kobj);
>         struct cros_ec_dev *ec = to_cros_ec_dev(dev);
>
>         if (a == &dev_attr_kb_wake_angle.attr && !ec->has_kb_wake_angle)
> diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
> index 46482d1..f3a70a3
> --- a/drivers/platform/chrome/cros_ec_vbc.c
> +++ b/drivers/platform/chrome/cros_ec_vbc.c
> @@ -17,7 +17,7 @@ static ssize_t vboot_context_read(struct file *filp, struct kobject *kobj,
>                                   struct bin_attribute *att, char *buf,
>                                   loff_t pos, size_t count)
>  {
> -       struct device *dev = container_of(kobj, struct device, kobj);
> +       struct device *dev = kobj_to_dev(kobj);
>         struct cros_ec_dev *ec = to_cros_ec_dev(dev);
>         struct cros_ec_device *ecdev = ec->ec_dev;
>         struct ec_params_vbnvcontext *params;
> @@ -57,7 +57,7 @@ static ssize_t vboot_context_write(struct file *filp, struct kobject *kobj,
>                                    struct bin_attribute *attr, char *buf,
>                                    loff_t pos, size_t count)
>  {
> -       struct device *dev = container_of(kobj, struct device, kobj);
> +       struct device *dev = kobj_to_dev(kobj);
>         struct cros_ec_dev *ec = to_cros_ec_dev(dev);
>         struct cros_ec_device *ecdev = ec->ec_dev;
>         struct ec_params_vbnvcontext *params;
> --
> 2.7.4
>