Subject: Re: [PATCH 04/10] -mm  clocksource: add some new API calls
From: Thomas Gleixner <tglx@linutronix.de>
Reply-To: tglx@linutronix.de
To: Daniel Walker <dwalker@mvista.com>
Cc: john stultz <johnstul@us.ibm.com>, akpm@osdl.org,
       linux-kernel@vger.kernel.org
In-Reply-To: <1154719720.12936.50.camel@c-67-188-28-158.hsd1.ca.comcast.net>
References: <20060804032414.304636000@mvista.com>
	 <20060804032521.464282000@mvista.com>
	 <1154718400.5327.23.camel@localhost.localdomain>
	 <1154719720.12936.50.camel@c-67-188-28-158.hsd1.ca.comcast.net>
Content-Type: text/plain
Date: Fri, 04 Aug 2006 23:05:02 +0200
Message-Id: <1154725503.5932.251.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 862
Lines: 27

On Fri, 2006-08-04 at 12:28 -0700, Daniel Walker wrote:
> > >  int clocksource_register(struct clocksource *c)
> > >  {
> > >  	int ret = 0;
> > >  	unsigned long flags;
> > >  
> > > +	if (unlikely(!c))
> > > +		return -EINVAL;
> > > +
> > 
> > I'm not sure I understand the need for this. Is it really likely someone
> > would pass NULL to clocksource_register()?
> 
> Not likely, I was just covering all possibilities.. It might be better
> as a BUG_ON() actually.

BUG_ON is the only thing, which can be correct here. Registering a NULL
clocksource simply is a bug, but even the BUG_ON is overkill here. 

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/